Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting checklist completion] [Wave 6: Workspace Chats] Expense - 'Marked as reimbursed' message in expense report is not wrapped #32286

Closed
1 of 6 tasks
lanitochka17 opened this issue Nov 30, 2023 · 40 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 30, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.6.2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32157

Action Performed:

Precondition:

  • User is an employee of a Collect workspace
  1. Log in to ND as the employee
  2. Go to the workspace chat > + > Request money
  3. Create a manual request
  4. As admin, pay the request
  5. As employee, tap on the expense preview to open the paid expense report

Expected Result:

The reimbursement message at the top is wrapped

Actual Result:

The reimbursement message at the top is not wrapped

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6296257_1701363889492.Screen_Recording_20231130_233045_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010ff3867dd75517b9
  • Upwork Job ID: 1734928173565202432
  • Last Price Increase: 2023-12-13
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 30, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 30, 2023
@mountiny mountiny self-assigned this Nov 30, 2023
@mountiny
Copy link
Contributor

Not a blocker, this is a feature behind beta and normal customers cant see this now.

Callstack can help us with this

@rezkiy37
Copy link
Contributor

rezkiy37 commented Dec 1, 2023

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

@mountiny
Copy link
Contributor

mountiny commented Dec 1, 2023

Thanks!

@rezkiy37
Copy link
Contributor

rezkiy37 commented Dec 1, 2023

Guys, I've tried to reproduce the bug. However, the app displays the message correctly. Also, styles looks good for the component. So, @lanitochka17, could you please confirm that you still can reproduce the bug?

cc @mountiny

1 2
3.mov
4

@melvin-bot melvin-bot bot added the Overdue label Dec 4, 2023
@rezkiy37
Copy link
Contributor

rezkiy37 commented Dec 4, 2023

@mountiny, so, can we close this one or...?

@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2023
@mountiny
Copy link
Contributor

mountiny commented Dec 4, 2023

I will bump QA to retest

@lanitochka17
Copy link
Author

Issue is reproducible on Android/Chrome. Build -1.4.8-1

Screenshot_20231207-010649_Chrome

@melvin-bot melvin-bot bot added the Overdue label Dec 6, 2023
@rezkiy37
Copy link
Contributor

rezkiy37 commented Dec 7, 2023

@lanitochka17, just tried to reproduce on 2 different emulators:

Screenshot 2023-12-07 at 12 10 25

Also tried on a real device:

image

So, the app looks good. Are you able to test on another device?

cc @mountiny

@melvin-bot melvin-bot bot removed the Overdue label Dec 7, 2023
@lanitochka17
Copy link
Author

@rezkiy37 After testing on the SG A50/Chrome phone, the problem was not reproduced

viber_image_2023-12-07_09-23-53-404

@rezkiy37
Copy link
Contributor

rezkiy37 commented Dec 7, 2023

Vit found a difference that causes a bug. It happens with a really long email. So, the bug is relevant. Sorry for additional attention 😅

Screenshot 2023-12-07 at 18 28 07

@rezkiy37
Copy link
Contributor

rezkiy37 commented Dec 8, 2023

Working on a fix.

@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2023
@rezkiy37
Copy link
Contributor

Still working on a fix.

@rezkiy37
Copy link
Contributor

Preparing a proposal.

@melvin-bot melvin-bot bot added Daily KSv2 Weekly KSv2 and removed Daily KSv2 labels Dec 27, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-12-28] [Wave 6: Workspace Chats] Expense - 'Marked as reimbursed' message in expense report is not wrapped [HOLD for payment 2024-01-03] [HOLD for payment 2023-12-28] [Wave 6: Workspace Chats] Expense - 'Marked as reimbursed' message in expense report is not wrapped Dec 27, 2023
Copy link

melvin-bot bot commented Dec 27, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @Ollyws requires payment (Needs manual offer from BZ)
  • @rezkiy37 does not require payment (Contractor)

Copy link

melvin-bot bot commented Dec 27, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
  • [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@Ollyws] Determine if we should create a regression test for this bug.
  • [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added the Overdue label Jan 4, 2024
@mountiny mountiny changed the title [HOLD for payment 2024-01-03] [HOLD for payment 2023-12-28] [Wave 6: Workspace Chats] Expense - 'Marked as reimbursed' message in expense report is not wrapped [HOLD for payment 2024-01-03] [Wave 6: Workspace Chats] Expense - 'Marked as reimbursed' message in expense report is not wrapped Jan 5, 2024
@bfitzexpensify bfitzexpensify added Daily KSv2 and removed Weekly KSv2 labels Jan 5, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 5, 2024
@bfitzexpensify
Copy link
Contributor

Offer sent @Ollyws

@melvin-bot melvin-bot bot added the Overdue label Jan 8, 2024
@bfitzexpensify
Copy link
Contributor

Payment complete, please complete the BZ checklist when you get a chance @Ollyws - thank you!

Copy link

melvin-bot bot commented Jan 8, 2024

@Ollyws, @mountiny, @bfitzexpensify, @rezkiy37 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@bfitzexpensify
Copy link
Contributor

Bump on the BZ checklist - thanks @Ollyws

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 9, 2024
@bfitzexpensify
Copy link
Contributor

I'm going to be mostly ooo until Jan 29, assigning a second BZ team member to keep an eye on this.

  • final step here is the completion of the BZ checklist by @Ollyws

@melvin-bot melvin-bot bot removed the Overdue label Jan 11, 2024
@bfitzexpensify bfitzexpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jan 11, 2024
Copy link

melvin-bot bot commented Jan 11, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@twisterdotcom twisterdotcom changed the title [HOLD for payment 2024-01-03] [Wave 6: Workspace Chats] Expense - 'Marked as reimbursed' message in expense report is not wrapped [Awaiting checklist completion] [Wave 6: Workspace Chats] Expense - 'Marked as reimbursed' message in expense report is not wrapped Jan 11, 2024
@Ollyws
Copy link
Contributor

Ollyws commented Jan 15, 2024

BugZero Checklist:

  • The PR that introduced the bug has been identified. Link to the PR:

#29309

  • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#29309 (comment)

  • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

  • Determine if we should create a regression test for this bug.

Yes but I think it's only worth it on the monthly tests.

  • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition:

User is an employee of a Collect workspace.
Admin that approves your expense requests, must have a really long email.

1. Log in to ND as the employee.
2. Go to the workspace chat > + > Request money.
3. Create a manual request.
4. Submit the request.
5. Tap on the expense preview to open the paid expense report.
6. Verify that an admin's email is wrapped.

Do we agree 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
Development

No branches or pull requests

6 participants