Standardize on type-only imports

[roryabraham]

Slack context: https://expensify.slack.com/archives/C01GTK53T8Q/p1701371123201489

Problem

We are inconsistent about how we import types. Type-only imports are preferred because they disappear at runtime, making the program more lightweight. It also improves code clarity because it's obvious that a type is being imported and not some other value.

Solution

Enable the consistent-type-imports lint rule w/ prefer: type-imports

Issue Owner

Current Issue Owner: @chrispader

[roryabraham]

cc @blazejkustra @fabioh8010 @chrispader can one of you comment for assignment please?

[chrispader]

@blazejkustra you wanted to take this one? Otherwise i can also open a PR :)

[blazejkustra]

@chrispader Sure, you can take it 😄

[chrispader]

Created the PR here: #32475

[melvin-bot]

This issue has not been updated in over 15 days. @chrispader, @roryabraham eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[roryabraham]

We're waiting on an upstream PR from @chrispader here. This isn't very high priority, so I'm not opposed to just closing this out for now so it's not a distraction. Up to you @chrispader

[chrispader]

Starting to work on this now! Got some spare cycles..

cc @roryabraham @blazejkustra @fabioh8010

[chrispader]

Turns out, we don't need an upstream change 🎉 There's a rule for enforcing type specifier style:

https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/consistent-type-specifier-style.md

PR updated and ready for review 🚀

[chrispader]

@roryabraham i think we can merge this one :)

[roryabraham]

@chrispader what one? 😄 I already merged #32475 last week.

That said, I think we can close this issue out since it was a compile-time-only change and we didn't use a C+ so no additional payments are due