[HOLD for 31909][$500] Task – Impossible click the checkbox to Complete the task as user B in 1:1 DM

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.7-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with any account.
3. Navigate to a 1:1 conversation with a user
4. Click on the + in the compose box and select "Assign task"
5. Enter a Title and press Next/ Confirm task
6. Login as user B of this conversation
7. Find newly created task and click the checkbox to Complete the task

Expected Result:

It is possible click the checkbox to Complete the task as user B in 1:1 DM

Actual Result:

Impossible click the checkbox to Complete the task as user B in 1:1 DM

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6297941_1701464933840.checkbox_to_Complete_the_task.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012cd4de2ef7be60b7
• Upwork Job ID: 1730710175306096640
• Last Price Increase: 2023-12-01

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012cd4de2ef7be60b7

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[abzokhattab]

Related to #31909

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Impossible click the checkbox to Complete the task as user B in 1:1 DM

What is the root cause of that problem?

In here, we're trying to completeTask with the props.taskReport and extract the id from the taskReport inside completeTask. However, the task report will not be available in user B Onyx data until they open the task report. So the taskReport.reportID is undefined and user B is unable to complete the task.

What changes do you think we should make in order to solve the problem?

Use props.taskReportID directly, in completeTask, reopenTask, we only need that field.

• In here, modify to accept the taskReportID directly (same for reopenTask)
• In here, pass in the props.taskReportID instead, same for other places that are using completeTask and reopenTask

It seems that if user B did not open the task before, CompleteTask API call is currently returning error, we should fix that in the back-end.

What alternative solutions did you explore? (Optional)

NA

[lschurr]

Could you review the proposal here @c3024?

[c3024]

This from #31909 might fix this as well.

The proposal suggestion is fine for toggling the checkmark but does not fix the bug of task completion. This needs to be fixed from backend. I think we should hold this till #31909 gets fixed.

[lschurr]

Alright, thanks. I've added the hold.

[lschurr]

On hold.

[lschurr]

On hold.

[lschurr]

hold.

[lschurr]

On hold.

[lschurr]

On hold.

[lschurr]

On hold.

[lschurr]

On hold.

[c3024]

#31909 is closed. This is fixed as well. The other user should not be able to check the task. This is expected behaviour.

taskDisabled.mp4

This issue can be closed.

@lschurr