Room - Error "You can't rename the report of a free plan" when renaming the room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.8-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any room
3. Click on the room header > Settings
4. Click Room name
5. Rename the room and save it

Expected Result:

User is able to rename the room

Actual Result:

User is able to rename the room. The error "You can't rename the report of a free plan" shows up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6301693_1701773683277.bandicam_2023-12-05_15-22-23-947.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[johnmlee101]

I think this is expected. @chiragsalian made the change here: https://github.com/Expensify/Web-Expensify/pull/39888

[johnmlee101]

Or at least to some degree, checking in if its necessary to have it apply to chats, otherwise should be an easy fix

[johnmlee101]

Have a easy fix ready if need be, but will wait on confirmation

[chiragsalian]

So here is the recent discussion - slack post.

if the report is under a free policy then don’t allow report name edits in oldDot
We should not support custom report naming on the Free plan.

But with that said in your video it looks like you are editing a policy room and its not allowing you to edit it. Thats odd. I guess we should update the code so that it allows chats room names to be updated. Do you have the fix ready @johnmlee101, i can review it if you send it my way?

[chiragsalian]

Btw this is not a blocker since the code effecting this is on web-e and its on production too.

[johnmlee101]

Working on a fire but will send you it

[johnmlee101]

sent!

[melvin-bot]

@johnmlee101 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@johnmlee101 Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@johnmlee101 Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@johnmlee101 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@johnmlee101 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

This issue has not been updated in over 14 days. @johnmlee101 eroding to Weekly issue.

[johnmlee101]

oh this is fixed.