Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD on pull/32516] [$500] IOU - Receipt shows attachment icon when it is opened right after uploading a receipt #32487

Closed
4 of 6 tasks
lanitochka17 opened this issue Dec 5, 2023 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 5, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.8-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to 1:1 DM
  3. Click + > Request money > Manual
  4. Create a manual receipt without receipt
  5. Click on the IOU preview twice to open IOU details page
  6. Click on the upload receipt window and upload a receipt
  7. Right after uploading the receipt, click on the receipt
    Note that it shows attachment icon while the receipt is loading

Expected Result:

The receipt will show a spinner when it is loading

Actual Result:

The receipt attachment icon while it is loading

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6301744_1701776981343.bandicam_2023-12-05_15-23-35-941.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b2f18a17342b1055
  • Upwork Job ID: 1732060054439260160
  • Last Price Increase: 2023-12-05
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 5, 2023

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Julesssss
Copy link
Contributor

We should fix this, but this should definitely not block the release.

Wasn't able to reproduce on Android

@Julesssss Julesssss added Daily KSv2 Hourly KSv2 External Added to denote the issue can be worked on by a contributor Bug Something is broken. Auto assigns a BugZero manager. and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Daily KSv2 labels Dec 5, 2023
Copy link

melvin-bot bot commented Dec 5, 2023

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot changed the title IOU - Receipt shows attachment icon when it is opened right after uploading a receipt [$500] IOU - Receipt shows attachment icon when it is opened right after uploading a receipt Dec 5, 2023
Copy link

melvin-bot bot commented Dec 5, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b2f18a17342b1055

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 5, 2023
Copy link

melvin-bot bot commented Dec 5, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Dec 5, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

@situchan
Copy link
Contributor

situchan commented Dec 5, 2023

Seems like regression from #31467

@situchan
Copy link
Contributor

situchan commented Dec 5, 2023

Confirmed regression came from #31467.
cc: @dukenv0307 @mananjadhav @mountiny

Not happening on 0e3a005

regression

@twisterdotcom
Copy link
Contributor

Should we assign to @dukenv0307 to fix?

@situchan
Copy link
Contributor

situchan commented Dec 5, 2023

being reverted here so I think we can close this after deploy to staging and verify fix

@twisterdotcom twisterdotcom removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Dec 5, 2023
@twisterdotcom twisterdotcom changed the title [$500] IOU - Receipt shows attachment icon when it is opened right after uploading a receipt [HOLD on pull/32516] [$500] IOU - Receipt shows attachment icon when it is opened right after uploading a receipt Dec 5, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 8, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants