-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-03-11] [$500] Chat - Popup window appears that can't close tapping outside #32610
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @marcaaron ( |
I think it can't really be a blocker really because it's a new feature in any case. If there is an existing modal that won't close - let's look into it, but otherwise, not a blocker IMO. |
Woops sorry I meant to just remove the blocker. We could fix this, but it's a low priority thing. |
Triggered auto assignment to @Christinadobrzyn ( |
Bug0 Triage Checklist (Main S/O)
|
@marcaaron Isn't this intended where the user has to click on the Got it button to close the modal as it is not a kind of confirmation modal bcoz we already switched to the focus mode? Otherwise to fix we just need to provide |
Not sure I understood you, sorry. I think that tapping outside the modal should dismiss it. It's just not a deploy blocker. Thanks! |
ProposalPlease re-state the problem that we are trying to solve in this issue.FocusModeNotification modal doesn't dismiss when tap outside What is the root cause of that problem?There's no App/src/components/FocusModeNotification.js Lines 20 to 25 in 43b1722
What changes do you think we should make in order to solve the problem?define onCancel same as onConfirm
|
Ok, I thought the user needed to compulsorily press the button to proceed with this acceptance modal and it should not close on backdrop click. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Modal is not dismissing on outside click for focus modal What is the root cause of that problem?We have not provided the logic for App/src/components/FocusModeNotification.js Lines 20 to 25 in 43b1722
What changes do you think we should make in order to solve the problem?
|
I can reproduce this, I think we should just fix this since it's not related to any other #focus mode GHs and if we want to keep the popup, we should just make it work now. Asking how we want this popup to work - https://expensify.slack.com/archives/C01SKUP7QR0/p1701982931866569 |
It sounds like the behaviour is:
Because the behaviour will be the same if they dismiss the pop-up or click "Got it" - we should force them to click "Got it" as an attempt to get them to read about #focus mode. So let's do nothing here and come back to this if we want to change it. |
I don't think the default here should be that, if you click the only green button or outside the box, that the behaviour changes? The default should be 'shit doesn't change' unless you actively, actually click something that clearly states you want to make the change (which i don't think is what we're doing here, right?) |
Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new. |
Raising PR shortly |
This issue has not been updated in over 15 days. @GabiHExpensify, @luacmartins, @rushatgabhane, @Christinadobrzyn, @neonbhai, @dubielzyk-expensify eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
working on the PR, finalizing soon! |
@neonbhai do you need any help? Could you please move forward the PR #34069 (review) |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-03-11. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
|
@Christinadobrzyn could you please attach payment summary. thanks 🙇 |
money request here - https://staging.new.expensify.com/r/7597420492097120 |
Payouts due: Contributor: $500 @neonbhai (paid in Upwork - https://www.upwork.com/nx/wm/workroom/35959554/overview) Upwork job is here. Regression test posted - https://github.com/Expensify/Expensify/issues/377899 Closing! |
$500 approved for @rushatgabhane based on summary. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.9-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Precondition: use an account you haven't logged in with yet today
Expected Result:
The popup closes by tapping outside & focus mode is enabled based on - https://expensify.slack.com/archives/C01SKUP7QR0/p1701987845872109?thread_ts=1701982931.866569&cid=C01SKUP7QR0
About this popup: it has an nvp. it can only be triggered once. anyone with 30 or more chats is the trigger.
Actual Result:
The popup doesn't close
Focus mode activates automatically
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6303868_1701912055210.Record_2023-12-07-02-32-11_4f9154176b47c00da84e32064abf1c48.mp4
Bug6303868_1701912055198.bandicam_2023-12-07_02-40-10-498.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: