[HOLD for payment 2024-02-07] [$500] Expense - Green dot does not appear in LHN when the request is created in workspace chat

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.11-13
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com.
2. Create a new workspace.
3. Click FAB > Request money > Manual.
4. Request money from a workspace chat.
5. Note that the green dot appears in the workspace chat in LHN after the request is created.
6. Create a new workspace.
7. Go to the workspace chat > + > Request money.
8. Create a manual expense in the workspace chat.
9. Click on the expense preview to open report page.
10. Return to the main chat.

Expected Result:

In Step 8. the green dot will appear next to workspace chat in LHN.

Actual Result:

In Step 8. the green dot does not appear next to the workspace chat in LHN, when the request is created in the workspace chat.
In Step 10, the green dot only appears after opening report page and returning to the main chat.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6310526_1702391036743.bandicam_2023-12-12_18-51-52-627__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013b75f81794691835
• Upwork Job ID: 1734657794835312640
• Last Price Increase: 2023-12-19
• Automatic offers:
• getusha | Reviewer | 28066191
• tienifr | Contributor | 28066192

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[shubham1206agra]

I am gonna investigate this one in the meantime

[shubham1206agra]

I am unable to repro this. I am not seeing Green Dot Indicator in both cases

[luacmartins]

I can't reproduce either, but I think that we should show the green dot. It shows up if you navigate to another report and then back to the workspace chat.

[shubham1206agra]

True, but same behaviour is in prod I think. @kbecciv Can you confirm this?

[luacmartins]

In prod the workspace chat just disappears from the LHN in focus mode lol

[shubham1206agra]

In prod the workspace chat just disappears from the LHN in focus mode lol

Same in DEV

[shubham1206agra]

In normal mode too

[luacmartins]

Dev had the same behavior as staging for me

[luacmartins]

I think we're missing hasOutstandingChildRequest in the chat report

[luacmartins]

I'm gonna demote this to NAB since the prod behavior is also broken.

[shubham1206agra]

Can I take this as C+ here?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013b75f81794691835

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[luacmartins]

Hmm in that case I believe being an admin should take precedence and we should show the green indicator, since the user/admin should act on the request.

[nkuoch]

Back end PR in review: https://github.com/Expensify/Auth/pull/9514

[getusha]

@nkuoch is the Backend PR merged?

[nkuoch]

yes!

[dylanexpensify]

Nice! @getusha what's left here?

[getusha]

@dylanexpensify reviewing the PR, currently having an issue while inviting other account to a workspace to test more cases.

[dylanexpensify]

Got it - have we resolved this @getusha? 🙇‍♂️

[getusha]

@dylanexpensify yes, i found a workaround for that issue. will complete the review today.

[dylanexpensify]

pending payout next

[getusha]

PR is merged, and pending to be deployed to staging.

[dylanexpensify]

Nice!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Green dot does not appear in LHN when the request is created in workspace chat #33398

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @getusha requires payment automatic offer (Reviewer)
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha] Determine if we should create a regression test for this bug.
• [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[getusha]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@getusha] The PR that introduced the bug has been identified. Link to the PR: N/a looks like a case we missed that required Back-End changes.
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/a
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@getusha] Determine if we should create a regression test for this bug. Yes
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Create a workspace.
2. Open the workspace chat
3. Press + > Manual > Request Money from the workspace chat
4. Verify that the green dot appears next to workspace chat in LHN.

Do we agree 👍 or 👎

[dylanexpensify]

today!

[dylanexpensify]

Payment summary:

• Contributor: @tienifr $500
• Contributor+: @getusha $500

[dylanexpensify]

done!