[$500] [HOLD for payment 2023-12-29] [HOLD for payment 2023-12-28] Android - All message displayed instead of last 3 when switching to another chat

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.14.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31762

Action Performed:

1. Log in
2. Accept prompt for notification permission
3. Open concierge chat
4. Send 3 messages to yourself
5. Verify notifications display for the messages
6. Switch to the chat
7. Verify those notifications are cleared
8. Switch away from the app
9. On native, go to the home screen
10. Send another 3 messages to yourself
11. Switch back to the app
12. Verify those notifications are cleared
13. Switch to the concierge chat
14. Send another 3 messages to yourself
15. Switch to other chats (not the one with the messages)
16. Verify those notifications are NOT cleared

Expected Result:

Should be 3 messages displayed

Actual Result:

All message displayed instead of last 3 when switching to another chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6321481_1703088047157.Screen_Recording_20231220_092859_New_Expensify__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014d520e3b819d9956
• Upwork Job ID: 1745092726620999680
• Last Price Increase: 2024-01-10

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[johnmlee101]

So to clarify, switching to another chat should clear all of the previous notifications, is what you're saying?

[johnmlee101]

cc @arosiclair not sure if this is relevant with the notifications, is that expected?

[arosiclair]

I think this part is unexpected:

The first 6 messages in that thread shouldn't be shown since they were cleared before. This is probably because they weren't cleared from the cache we have here.

[arosiclair]

I can try reproducing this in dev and see if there's a quick fix

[johnmlee101]

Good catch!

[johnmlee101]

Any luck here?

[arosiclair]

Sorry just getting back to this now

[arosiclair]

I can reproduce this in dev.

Honestly, I'm not sure there's an easy fix for this. Normally when notifications are dismissed our native callback runs and clears the notification from the cache here. However, when we use JS APIs to clear notifications when you open a report (here), it looks like those native callbacks don't get called so the cache is not updated.

We could try adding a Native Module to clear the cache manually, but I don't think there's an easy way to get a reference to the NotificationCache from that context.

This functionality is working well on all other platforms, so I'm tempted to just disable the feature on Android and figuring out a fix later. What do you think @johnmlee101?

[johnmlee101]

Yeah that works for me 👍 let's take the time to do it right

[arosiclair]

Posted a PR, but gotta sign off and go OOO for the rest of the week

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Disable clearReportNotifications on Android #33386

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@johnmlee101, @arosiclair Eep! 4 days overdue now. Issues have feelings too...

[fedirjh]

cc @arosiclair could you please assign me as C+ reviewer fo the PR , thank you.

[melvin-bot]

@johnmlee101, @arosiclair Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[arosiclair]

@kevinksullivan can you just pay @fedirjh for his C+ review?

[melvin-bot]

@johnmlee101, @arosiclair, @kevinksullivan, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@johnmlee101, @arosiclair, @kevinksullivan, @fedirjh 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014d520e3b819d9956

[melvin-bot]

Current assignee @fedirjh is eligible for the External assigner, not assigning anyone new.

[kevinksullivan]

Sorry for the delay. @fedirjh offer was sent, lmk when you accept!

[fedirjh]

@kevinksullivan Thank you accepted.

[kevinksullivan]

All set