Scan - "Receipt scanning failed" is shown when "Unknown merchant" is not considered an error

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.15-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33220

Action Performed:

1. Create a Scan request using a receipt with Amount but no Merchant
2. When smartscanning is complete, open request details view

Expected Result:

Since "Unknown merchant" is no longer considered an error, it will not show "Receipt scanning failed" message

Actual Result:

It still shows "Receipt scanning failed" message when "Unknown merchant" is not considered an error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jasperhuangg]

It looks like this error is being displayed here: https://github.com/Expensify/Auth/blob/main/auth/command/EditMoneyRequest.cpp#L375-L403

@Gonals @sobitneupane is this the expected behavior when the user selects "Merchant is unclear"? I feel like it's a bit awkward, since they already specified that they weren't able to get a merchant from the receipt.

Regardless, I'm not going to block deploy on this–this can be fixed in a subsequent PR.

[melvin-bot]

@Gonals Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Gonals]

It looks like this error is being displayed here: https://github.com/Expensify/Auth/blob/main/auth/command/EditMoneyRequest.cpp#L375-L403

@Gonals @sobitneupane is this the expected behavior when the user selects "Merchant is unclear"? I feel like it's a bit awkward, since they already specified that they weren't able to get a merchant from the receipt.

Regardless, I'm not going to block deploy on this–this can be fixed in a subsequent PR.

You are very right. I'll fix that

[melvin-bot]

@Gonals Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Gonals]

This is done