[HOLD for payment 2024-01-05] [$500] Android - Request money - Suggested destination displayed instead of new one if entered offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.16-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open the app and log in
2. Create a distance expense on the workspace if there are not any
3. Navigate to the workspace chat
4. Disable internet connection
5. Tap "+" > Request money > Distance
6. Select a start waypoint from suggestions
7. Tap the "Start" and enter a new one
8. Repeat steps 6-7 for the finish waypoint
9. Tap "Request"
10. Open the request conversation and return online

Expected Result:

Newly entered destinations are displayed as start and finish

Actual Result:

Suggested destinations are displayed for the start and finish even after returning online. On the Distance expense receipt, the new address is shown below the suggested one

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6324075_1703257350644.video_2023-12-22_10-01-33.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a99352e561737912
• Upwork Job ID: 1738247677824786432
• Last Price Increase: 2023-12-22
• Automatic offers:
• cubuspl42 | Reviewer | 28070893
• dukenv0307 | Contributor | 28070894

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a99352e561737912

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Suggested destinations are displayed for the start and finish even after returning online. On the Distance expense receipt, the new address is shown below the suggested one

What is the root cause of that problem?

In here, we're not setting name of waypoint to null when saving waypoint in offline mode. This causes the new selected waypoint to retain the name of the old waypoint (Cody). We already did the same here in the old flow but it looks like we missed to implement the same for the new money request flow.

What changes do you think we should make in order to solve the problem?

In here, set name of waypoint to null when saving waypoint in offline mode, or can set to values.name || null.

We should do the same here.

Basically we should do the same as we did in this PR (which is for the old money request flow), but we do it for the new money request flow.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@cubuspl42, @conorpendergrast Whoops! This issue is 2 days overdue. Let's get this updated quick!

[cubuspl42]

@dukenv0307 Did you test the proposed changes? Have you confirmed that the changes previously applied to the old flow are suitable for the new flow?

[dukenv0307]

@cubuspl42 Yes I've tested and it works well 🚀

[cubuspl42]

I approve the proposal by @dukenv0307

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@cubuspl42 this PR is ready for review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.19-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add fallback value for name field #33692

If no regressions arise, payment will be issued on 2024-01-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment automatic offer (Reviewer)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
• [@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@cubuspl42] Determine if we should create a regression test for this bug.
• [@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[cubuspl42]

• The PR that introduced the bug has been identified. Link to the PR:
  • Refactor the money request creation flow #28618
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • https://github.com/Expensify/App/pull/28618/files#r1442811199
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • No need for additional discussion
• Determine if we should create a regression test for this bug.
  • Up to the QA team
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • Sign in to NewDot
  • Choose any workspace
  • Create a distance request on the workspace if there are not any
  • Navigate to the workspace chat
  • Go offline
  • Tap "+" > Request money > Distance
  • Select any start waypoint from suggestions
  • Tap the "Start" and enter a new name manually
  • Select any finish waypoint from suggestions
  • Tap the "Finish" and enter a new name manually
  • Tap "Request"
  • Open the request details from the chat
  • Verify that manually entered destinations are displayed as "Start" and "Finish"

[melvin-bot]

@cubuspl42, @conorpendergrast, @arosiclair, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[conorpendergrast]

Payouts due:

• Contributor: $500 @dukenv0307 (contract)
• Contributor+: $500 @cubuspl42 (contract)

Upwork job is here.

[conorpendergrast]

Paid, and contracts ended. This bug was identified by Applause via testing, so I suspect it's already covered under the existing regression testing. I'll close for now, but reopen if you disagree!