[HOLD for payment 2024-01-17] [$500] Grey box is shown instead of bank icon

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.18-1
Reproducible in staging?: y
Reproducible in production?: not able to check
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shubham1206agra
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1703677023896169

Action Performed:

1. Go to Workspace > Bank Account
2. Select Connect online via plaid
3. Select any bank, and complete the plaid process
4. Observe the icon next to bank name

Expected Result:

Bank Icon should be shown

Actual Result:

Grey Box is shown

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018bcfe6522be3b9f5
• Upwork Job ID: 1740403705181048832
• Last Price Increase: 2023-12-28
• Automatic offers:
• shubham1206agra | Contributor | 28071698
• Pujan92 | Contributor | 28071779

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Grey box is shown instead of bank icon in plaid bank account step

What is the root cause of that problem?

unnecessary fill prop is added to Icon in AddPlaidBankAccount

App/src/components/AddPlaidBankAccount.js

Lines 247 to 253 in 9e81447

	<Icon
	src={icon}
	height={iconSize}
	width={iconSize}
	additionalStyles={iconStyles}
	fill={theme.icon}
	/>

What changes do you think we should make in order to solve the problem?

remove that prop

Demo:

demo.mov

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank icon filled with grey color

What is the root cause of that problem?

In this PR, for many places we have added fill property to Illustrations or images. In some screenshots just showing the image issue in diff component.

• ImageCropView
• AddPlaidBankAccount
• DeeplinkRedirectLoadingIndicator
• ValidateCodeModal
• LogInWithShortLivedAuthTokenPage

What changes do you think we should make in order to solve the problem?

Remove fill property for Illustrations or images from all these components.

[shubham1206agra]

Sorry everyone, but I am working on this already actually. I just reported this for GH issue

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018bcfe6522be3b9f5

[melvin-bot]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[mountiny]

this indeed has already been worked on by @shubham1206agra

This is not a blocker since this is already in production

Taking over since I was involved in the similar fixes @srikarparsi if thats ok

[shubham1206agra]

@dannymcclain You need to comment that which design is better in case of ImageCropView. The different view is in #33607 (comment)

[shawnborton]

Ah, I had reported something similar here

But yeah, seems like the bank account icon went missing and we should be showing the default bank icon when we don't have a logo available to us. cc @grgia @madmax330 in case you have more context too

[mountiny]

@shawnborton i think thank bank icon issue should be handled already in the PR, but @shubham1206agra has this question they need help with #33607

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixed icon fill colors #33607

If no regressions arise, payment will be issued on 2024-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment automatic offer (Contributor)
• @shubham1206agra requires payment automatic offer (Contributor)
• @shubham1206agra requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[shubham1206agra]

False alert above as PR is already in prod.

[slafortune]

@Pujan92 - Paid 👍
@shubham1206agra can you complete the checklist above and also accept this offer

[slafortune]

@shubham1206agra will you be able to complete the above checklist in the next day or two?

[shubham1206agra]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: Expo image #30905
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30905/files#r1463416802
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1706022333430269
• [@shubham1206agra] Determine if we should create a regression test for this bug. No
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[slafortune]

Thanks @shubham1206agra Pd 👍