Web - Search - The last result in search page is not visible when pressing up key

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.18-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Click on 'Search' icon
2. Press up key

Expected Result:

The last result should be visible

Actual Result:

Last result is not visible. It is only made visible by scrolling the list up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6327024_1703708911875.Screen_Recording_2023-12-27_at_11.27.04_at_night.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[iwiznia]

Sorry, but I don't get what this issue is saying. Is the scroll in the video happening automatically? If so, I can't reproduce it...

Screen.Recording.2023-12-27.at.3.38.07.PM.mov

[iwiznia]

Conversation here https://expensify.slack.com/archives/C9YU7BX5M/p1703713279179439

[iwiznia]

I need to look into this more, but given I see the same behavior in my account in production and that applause is reproducing inconsistently (see link above) I think this is not a blocker.

[abzokhattab]

@iwiznia let us know once you find out how to reproduce it. Thanks

[iwiznia]

Steps to reproduce (not in all accounts):

• Open search
• Press arrow up
• Check how it DOES NOT scroll you down to the bottom to show the last contact selected

[Pujan92]

It is due to the extra line height which makes the option row of 71px, but in getItemLayout we consider it 64px. Will be fixed after this PR is merged.

[iwiznia]

Awesome, that PR is being CPed and we can test.

[mountiny]

Screen.Recording.2023-12-28.at.21.29.19.mov

I think this is fixed and can be closed

[iwiznia]

Nope, still bad for me, but should not block deploy since it's also bad for me in production

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[JmillsExpensify]

Why is this even an issue? Did we support it and break it? I'm mainly asking because we really don't support keyboard navigation holistically throughout the app.

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@JmillsExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@JmillsExpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@JmillsExpensify 12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

@JmillsExpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

This issue has not been updated in over 14 days. @JmillsExpensify eroding to Weekly issue.

[JmillsExpensify]

Still not clear what's going on here.

[JmillsExpensify]

Additionally, we don't officially support keyboard navigation so I'm going to close this issue.