[HOLD for payment 2024-01-09] [HOLD for payment 2024-01-05] Mweb/Chrome - IOU - Scan page keeps loading infinitely

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.19
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap fab
3. Tab request money
   4.Tap Scan

Expected Result:

Scan page must be displayed properly and it must not load infinitely

Actual Result:

Scan page keeps loading infinitely

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6327927_1703803005223.az_recorder_20231229_032924.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

#32577 is the offending PR confirmed with revert

test branch - https://github.com/ishpaul777/App/tree/revert-32577-perf/request-money-tabs-animation

[marcaaron]

Thanks @ishpaul777. Will wait to see what @mountiny wants to do here.

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue

Mweb/Chrome - IOU - Scan page keeps loading infinitely

What is the root cause of that problem?

This is happening because we disabled animation here for web platforms https://github.com/Expensify/App/pull/32577/files#r1437995158.

And we use useTabNavigatorFocus in NavigationAwareCamera, which relies on useTabAnimation(). Since we have disabled the Navigation, the camera never loads as useTabAnimation() retuers null (or error), and will make shouldShowCamera to false always.

What changes do you think we should make in order to solve the problem?

Remove useTabNavigatorFocus, and related code for web platforms as we no longer have animation for that. Do the same for RecieptSelector.

Result:

Screen.Recording.2023-12-29.at.11.08.46.AM.mov

What alternative solutions did you explore? (Optional)

We can split useTabNavigatorFocus for 2 different platforms web and native, and remove use of useTabAnimation in web code

[shubham1206agra]

@kacper-mikolajczak Can you check the above proposal ^ ?

[mountiny]

Thanks @marcaaron I will take over this blocker as deployer

[mountiny]

@kacper-mikolajczak is making the PR

[kacper-mikolajczak]

Can you check the above proposal ^ ?

Hey @shubham1206agra thanks for the proposal, please take a look at the implementation here #33754 and let me know what you think 👍

Quick summary:

Based on the investigations from intial proposal by @shubham1206agra, this PR aims to re-implement useTabNavigatorFocus hook for web-based platforms. Takeaways:

Current implementaiton uses animation state in order to detect active tab.

This solution uses navigation state (index) to detect that, which seems to be better source of truth than animation state.

Navigation state solution was used before, but it introduced stuttering

While investigating behaviour of useNavigationState hook it seems that it has some issues with outputting latest state (it tends to interleave last and current index values). In order to avoid that, we used custom hook that should not have such issue.

CC @mountiny @shubham1206agra

[mountiny]

We decided to revert as the fix was not straightforwards and the regression was complete increasing chances of some other issues slipping through

[mountiny]

Reverted and CPed, going to handle this again next week on this issue #31190

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.19-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Fix RequestMoney tabs animations" #33761

If no regressions arise, payment will be issued on 2024-01-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)
• @kacper-mikolajczak does not require payment (Contractor)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.20-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Fix RequestMoney tabs animations" #33761

If no regressions arise, payment will be issued on 2024-01-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)
• @kacper-mikolajczak does not require payment (Contractor)