-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] IOU - No error message when changing amount of a paid request #33799
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01064a73e07695ea66 |
Triggered auto assignment to @MitchExpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.IOU - No error message when changing amount of a paid request What is the root cause of that problem?This happens as we don’t check if the request is paid before calling App/src/pages/EditRequestPage.js Lines 123 to 136 in 8cb48e4
What changes do you think we should make in order to solve the problem?We should add a check to see if the request is paid using App/src/pages/EditRequestPage.js Lines 127 to 131 in 8cb48e4
We could also use Alternatively:
|
ProposalPlease re-state the problem that we are trying to solve in this issue.What is the root cause of that problem?The backend is returning the correct error message, however we don't expect it because we are not handling it in the What changes do you think we should make in order to solve the problem?Get the errors from the App/src/components/ReportActionItem/MoneyRequestView.js Lines 201 to 202 in 8cb48e4
Pseudo-code
What alternative solutions did you explore? (Optional)
|
The expected result is weird to me, why would we tell the user an "unexpected error" occurs if it's expected that you cannot edit a settled amount? Why don't we just tell the user they cannot edit a settled amount if that is indeed expected? |
Is it intentional a user can edit a paid request's amount? Wouldn't that lead to conflicts over how much was paid by who later on? |
This seems like an edge case , following the video , these are the detailed steps:
For other cases, when the amount is paid , you can't open the edit form. |
ProposalPlease re-state the problem that we are trying to solve in this issue.No error message shown for updating the paid amount transaction What is the root cause of that problem?It seems the issue occurs after this PR where we have used a new method to update an amount. For the failure case we don't have any report action error entry which isn't showing any error. Lines 990 to 1011 in 320ff54
What changes do you think we should make in order to solve the problem?Add an entry for the failureData in the onyx which sets error to that specific report action.
Like we have for the older method Lines 2195 to 2203 in 320ff54
ResultScreen.Recording.2024-01-02.at.16.28.17.mp4 |
@Pujan92 Thank you for the proposal, the root cause looks correct. I just retested with reverting #32533 and it's working as expected. For the solution, it looks good to me, I believe we should add the failure data inside 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @Pujan92 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Update: PR was merged and deployed to production #33880 (comment). It seems automation was not triggered for this one. |
Bump @MitchExpensify :) |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.20-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:
Expected Result:
Error message "Unexpected error editing the money request, please try again later" will show up when editing the amount of a settled request.
Actual Result:
Error message does not show up.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6328897_1703905910295.bandicam_2023-12-30_03-16-45-208.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: