IOU - In scan request, tapping download file shows error pop up

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.22
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch app
2. Tap fab--- Request money---Scan
3. Upload a corrupt pdf file
4. Select a contact
5. Tap request
6. Tap on request created and enter amount and merchant field
7. Tap in receipt and note error message can't upload file
8. Navigate back to scan request created and note error message "Receipt didn't upload, download the file. "
9. Tap download the file

Expected Result:

In scan request uploading corrupt pdf, tapping download file must allow user to download the file and it must show pop up message " Attachment downloaded successfully

Actual Result:

In scan request uploading corrupt pdf, tapping download file shows error pop up "Attachment cannot be downloaded"

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333325_1704473162365.load.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[situchan]

Not able to reproduce on latest main

[mvtglobally]

Still repro on build 1.4.22-2

gu6.mp4

[thienlnam]

https://expensify.slack.com/archives/C01GTK53T8Q/p1704699988214449?thread_ts=1704683805.547759&cid=C01GTK53T8Q

[kbecciv]

@thienlnam Reopening the issue. We might need a second chance to review it. This PR (#34087) introduced the issue where users can download the invalid file on step 6.

Screen_Recording_20240131_205428_New.Expensify.1.mp4

[srikarparsi]

I think this can still be closed since it's around handling a corrupt PDF and the error messages seem to be correct. cc @thienlnam if you feel differently