Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Regression: SHIFT+ENTER in message composer is NOT adding a new line #34249

Closed
iwiznia opened this issue Jan 10, 2024 · 12 comments
Closed
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Hourly KSv2

Comments

@iwiznia
Copy link
Contributor

iwiznia commented Jan 10, 2024

Problem

When you press SHIFT+ENTER in the message composer, a new line should be added to the message, but it is not doing that.

Only happening on staging

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012a447f5f0603d050
  • Upwork Job ID: 1745109902462763008
  • Last Price Increase: 2024-01-10
@iwiznia iwiznia added External Added to denote the issue can be worked on by a contributor Bug Something is broken. Auto assigns a BugZero manager. labels Jan 10, 2024
@melvin-bot melvin-bot bot changed the title Regression: SHIFT+ENTER in message composer is NOT adding a new line [$500] Regression: SHIFT+ENTER in message composer is NOT adding a new line Jan 10, 2024
Copy link

melvin-bot bot commented Jan 10, 2024

Job added to Upwork: https://www.upwork.com/jobs/~012a447f5f0603d050

Copy link

melvin-bot bot commented Jan 10, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Help Wanted Apply this label when an issue is open to proposals by contributors Daily KSv2 labels Jan 10, 2024
@iwiznia iwiznia added DeployBlockerCash This issue or pull request should block deployment and removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Jan 10, 2024
Copy link

melvin-bot bot commented Jan 10, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 10, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 10, 2024

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@AndrewGable
Copy link
Contributor

What client? Works fine for me on staging web?

Screen.Recording.2024-01-10.at.10.18.03.AM.mov

@AndrewGable
Copy link
Contributor

Cannot reproduce on staging desktop either

@iwiznia
Copy link
Contributor Author

iwiznia commented Jan 10, 2024

What client? Works fine for me on staging web?

Really? Staging web for me does not work!

@iwiznia
Copy link
Contributor Author

iwiznia commented Jan 10, 2024

So not sure what's going on but I definitely can reproduce this on web staging

@AndrewGable
Copy link
Contributor

@joekaufmanexpensify @alitoshmatov - Can you reproduce on staging web? I can ask in open source slack room if anyone else can reproduce.

@iwiznia
Copy link
Contributor Author

iwiznia commented Jan 10, 2024

lol I reloaded and it worked 😂

@iwiznia iwiznia closed this as completed Jan 10, 2024
@joekaufmanexpensify
Copy link
Contributor

Yep, working for me on web too!

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants