Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] "Hmm... it's not here" error message when navigating to "money2020" #34317

Closed
1 of 6 tasks
kavimuru opened this issue Jan 11, 2024 · 8 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kavimuru
Copy link

kavimuru commented Jan 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing #32164
Version Number: 1.4.24-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Log out
  2. Navigate to staging.new.expensify.com/money2020
  3. Log in with a expensifail new account

Expected Result:

You should be navigated to a new chat report, between your account & money2020@expensify.com.

Actual Result:

"Hmm... it's not here" error message when navigating to "money2020".

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6338565_1704956558306.bandicam_2024-01-11_05-57-53-491.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013946689ceb636208
  • Upwork Job ID: 1745350007262670848
  • Last Price Increase: 2024-01-11
@kavimuru kavimuru added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 11, 2024
@melvin-bot melvin-bot bot changed the title "Hmm... it's not here" error message when navigating to "money2020" [$500] "Hmm... it's not here" error message when navigating to "money2020" Jan 11, 2024
Copy link

melvin-bot bot commented Jan 11, 2024

Job added to Upwork: https://www.upwork.com/jobs/~013946689ceb636208

Copy link

melvin-bot bot commented Jan 11, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 11, 2024
Copy link

melvin-bot bot commented Jan 11, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@MelnykDmitro
Copy link

MelnykDmitro commented Jan 11, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reaching unlogged non existing URL doesn't cause redirect to not found page, however after logging in it navigates to not found page.

What is the root cause of that problem?

There is bug-like condition of React Navigation which causing unexpected reaching not found page. To replicate it user has to:

  • Reach not found page when there is no defined not found page in the stack navigator.
  • Reach changing of stack navigator to have not found page

What changes do you think we should make in order to solve the problem?

We can define not found screen in the PublicScreens to user lead to the HomeScreen. This way router won't reach not found page after authentication anymore.

What alternative solutions did you explore? (Optional)

Provide not found page in case unathenticated user reaches non existing page.

@VickyStash
Copy link
Contributor

I guess the demo flow related to money2020 was removed as a part of this PR, so it's an expected result and not a bug.

@MelnykDmitro
Copy link

I guess the demo flow related to money2020 was removed as a part of this PR, so it's an expected result and not a bug.

Yes, demo flow money2020 might be not relevant anymore. However there is still another bug with relates to any 404.

@mollfpr
Copy link
Contributor

mollfpr commented Jan 12, 2024

However there is still another bug with relates to any 404

Could you elaborate on it more or do you have some example for this kind of issue?

@melvin-bot melvin-bot bot added the Overdue label Jan 14, 2024
@mollfpr
Copy link
Contributor

mollfpr commented Jan 15, 2024

@muttmuure We can close this. The money2020 is removed, and the result is expected.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 15, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants