[TS migration] Implement useOnyx hook in react-native-onyx

[blazejkustra]

Typescript migration (react-native-onyx)

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

N/A

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

Will be handled by agencies

[roryabraham]

Co-assigning to handle reviews

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[roryabraham]

Putting on HOLD until it's picked up by an agency assignee

[roryabraham]

Pinged in slack: https://expensify.slack.com/archives/C0593T50UHG/p1705961669792889

[blazejkustra]

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue together with @fabioh8010

[fabioh8010]

Commenting for assignment too.

[fabioh8010]

Update: Still working on the doc, and started doing some tests with initial implementation.

[fabioh8010]

Update: useOnyx proposal doc created and sent to review!

Draft PR of POC implementation also created, but it's still experimental and WIP.

[roryabraham]

Link to the proposal in #expensify-open-source is here.

We've got a clear consensus to move forward, so the next step is to complete the implementation of the hook and open up the PR for reviews. I look forward to reviewing it.

@fabioh8010 @blazejkustra when do you estimate that will be ready?

[fabioh8010]

@roryabraham @blazejkustra Created a Draft PR and left an update, let's continue discussions there.

[fabioh8010]

PR is ready to review @roryabraham

[fabioh8010]

Update: PR still under review.

[ishpaul777]

Hey 👋 @roryabraham , Can you please assign me here

[roryabraham]

coming from https://expensify.slack.com/archives/C0593T50UHG/p1712936660132249, one more follow-up task ... let's return undefined instead of null for missing Onyx values

[roryabraham]

Also, @CortneyOfstad can we please issue a $250 payment to @ishpaul777 for their review of #38924? Thanks!

[CortneyOfstad]

Sorry for the delay here! @ishpaul777 — I sent you a manual offer in Upwork here. Please let me know once you accept and I can get that paid ASAP. Thanks!

[ishpaul777]

Thanks Accepted offer!

[fabioh8010]

coming from https://expensify.slack.com/archives/C0593T50UHG/p1712936660132249, one more follow-up task ... let's return undefined instead of null for missing Onyx values

Update: PR is up! cc @roryabraham @blazejkustra

[CortneyOfstad]

Thanks Accepted offer!

Payment completed @ishpaul777 — thank you!

[CortneyOfstad]

@roryabraham is anything else needed here, or can this be closed?

[fabioh8010]

coming from https://expensify.slack.com/archives/C0593T50UHG/p1712936660132249, one more follow-up task ... let's return undefined instead of null for missing Onyx values

Update: PR is up! cc @roryabraham @blazejkustra

@CortneyOfstad We are still working on this issue 🙂

[fabioh8010]

Update: I've opened the PR to review, but I put on HOLD because I'm going to be OOO next week, and will return on May 6th.

[CortneyOfstad]

Sounds good — thanks @fabioh8010!

[fabioh8010]

Update: I've took the PR off the hold state since I'm back now, so we can resume review.

[CortneyOfstad]

Waiting for the merge freeze to be lifted 👍

[CortneyOfstad]

Excuse my ignorance, but I see the PR is listed as "Published to npm in v2.0.37". Does that mean it is completed? I traditionally see it go through the flow of stating to production, but with it being Onyx, I just wanted to make sure I had this correct. Thanks! CC @roryabraham

[fabioh8010]

I think we can close this issue - The hook is implemented and already being used in E/App, and the last type improvement is merged and being handled in this Onyx bump PR, so I guess there is nothing left to do here. But I will leave to @roryabraham too to decide 😅

[CortneyOfstad]

Going to close — feel free to reopen @roryabraham if needed 👍