Chat - Enter key doesn't work when confirming saving deleted message from keyboard

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.24-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open Desktop App
2. Login with any account
3. Open any chat
4. Send message
5. Press Arrow Up Key
6. Verify that the last message in the chat enters edit mode
7. Delete all the text while editing the comment and save
8. Verify a modal is displayed for the user to confirm the message deletion
9. Press 'Enter' key to confirm

Expected Result:

User can press 'Enter' and message was deleted

Actual Result:

Enter key doesn't work when confirming saving deleted message from keyboard

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6339494_1705011399106.Desktop-Edit-Enter-Key-Not-work.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[francoisl]

Can't repro on v1.4.24-5. I don't know if pressing the arrow keys is supposed to do anything regarding focusing/unfocusing the confirmation button, but it doesn't seem to affect anything for me here. Going to ask someone else for a second attempt to repro.

Screen.Recording.2024-01-11.at.3.29.00.PM.mov

[francoisl]

#34313 (CP'ed as v1.4.24-5) was a fix for an isue with the Enter key in a different flow, and it most likely also fixed it for this modal.

I think we're good here, also double-checked with @NikkiWines she's not experiencing this.