-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-07] [Performance] Update the E2E tests to use real API responses #34797
Comments
Triggered auto assignment to @kadiealexander ( |
@hannojg can you comment so I can assign you |
Servus @mountiny 👋 |
The PR is good for review! @AndrewGable as I think you are internal most familiar with the setup of the e2e tests: |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-07. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@hannojg please don't forget about the regression test steps. |
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
@AndrewGable, @NikkiWines, @hannojg, @kadiealexander Huh... This is 4 days overdue. Who can take care of this? |
I think this issue should be all good, right? I don't think we need regression steps since this wasn't a regression but rather an adjustment to our existing E2E tests |
Ah sweet then! |
Problem
The E2E tests currently use hardcoded mocked data, but that does not reflect heavy user usage of the app as the amount of the data is not coming close to it.
Solution
Lets update the tests so they can authenticate with testing account and get actual data for special account, cache that and reuse it throughout the tests. This will ensure the tests mimic more closely actual user usage
@hannojg
Issue Owner
Current Issue Owner: @hannojgThe text was updated successfully, but these errors were encountered: