Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-07] [Performance] Update the E2E tests to use real API responses #34797

Closed
mountiny opened this issue Jan 19, 2024 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@mountiny
Copy link
Contributor

mountiny commented Jan 19, 2024

Problem

The E2E tests currently use hardcoded mocked data, but that does not reflect heavy user usage of the app as the amount of the data is not coming close to it.

Solution

Lets update the tests so they can authenticate with testing account and get actual data for special account, cache that and reuse it throughout the tests. This will ensure the tests mimic more closely actual user usage

@hannojg

Issue OwnerCurrent Issue Owner: @hannojg
@mountiny mountiny added Weekly KSv2 NewFeature Something to build that is a new item. labels Jan 19, 2024
@mountiny mountiny self-assigned this Jan 19, 2024
Copy link

melvin-bot bot commented Jan 19, 2024

@mountiny
Copy link
Contributor Author

@hannojg can you comment so I can assign you

@mountiny mountiny assigned NikkiWines and unassigned mountiny Jan 19, 2024
@hannojg
Copy link
Contributor

hannojg commented Jan 19, 2024

Servus @mountiny 👋

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jan 22, 2024
@hannojg
Copy link
Contributor

hannojg commented Jan 22, 2024

The PR is good for review! @AndrewGable as I think you are internal most familiar with the setup of the e2e tests:

@AndrewGable AndrewGable self-assigned this Jan 22, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 26, 2024
@melvin-bot melvin-bot bot changed the title [Performance] Update the E2E tests to use real API responses [HOLD for payment 2024-02-07] [Performance] Update the E2E tests to use real API responses Jan 31, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 31, 2024
Copy link

melvin-bot bot commented Jan 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

  • @hannojg does not require payment (Contractor)

Copy link

melvin-bot bot commented Jan 31, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hannojg] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Feb 6, 2024
@kadiealexander
Copy link
Contributor

@hannojg please don't forget about the regression test steps.

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2024
Copy link

melvin-bot bot commented Feb 7, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Copy link

melvin-bot bot commented Feb 12, 2024

@AndrewGable, @NikkiWines, @hannojg, @kadiealexander Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Feb 12, 2024
@NikkiWines
Copy link
Contributor

I think this issue should be all good, right? I don't think we need regression steps since this wasn't a regression but rather an adjustment to our existing E2E tests

@kadiealexander
Copy link
Contributor

Ah sweet then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

5 participants