Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Tag - "no longer valid" initially appears for Tag when request with a valid tag is created #34804

Closed
6 tasks done
lanitochka17 opened this issue Jan 19, 2024 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 19, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.28-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

  • User is an employee of Collect workspace on Old Dot which has tags
  1. Go to workspace chat and open manual request page
  2. Enter amount > Next > Show more
  3. Click Tag and select a tag
  4. Create the request
  5. Immediately open request details page
  6. Return to expense report and go to request details page again

Expected Result:

Since the selected tag is existing and valid, "no longer valid" will not appear on Tag row

Actual Result:

"no longer valid" appears on Tag row when the request details page is visited immediately after requesting it. It disappears when revisiting the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6347698_1705675090612.20240119_003524.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014d7530b698dd531e
  • Upwork Job ID: 1748356015802679296
  • Last Price Increase: 2024-01-19
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 19, 2024
Copy link

melvin-bot bot commented Jan 19, 2024

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot changed the title Tag - "no longer valid" initially appears for Tag when request with a valid tag is created [$500] Tag - "no longer valid" initially appears for Tag when request with a valid tag is created Jan 19, 2024
Copy link

melvin-bot bot commented Jan 19, 2024

Job added to Upwork: https://www.upwork.com/jobs/~014d7530b698dd531e

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 19, 2024
Copy link

melvin-bot bot commented Jan 19, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@lanitochka17
Copy link
Author

@cead22
Copy link
Contributor

cead22 commented Jan 19, 2024

I think there was a network request that failed in there, notice how the compose box is gone in the screenshot. Also, being able to selected a tag that isn't in the policy means you don't have the updated tags on the client, so we're either not sending the update, or the network failed there too. Can this be reproduced reliably?

image

@melvin-bot melvin-bot bot added the Overdue label Jan 22, 2024
@miljakljajic
Copy link
Contributor

@lanitochka17 is this still reproducible for you? I tried but I wasn't able to get up a tag list even though the collect workspace had tags on it. I was working in staging. Can anyone provide some more detail in the repro steps? (sorry!)

@melvin-bot melvin-bot bot removed the Overdue label Jan 23, 2024
@lanitochka17
Copy link
Author

@miljakljajic Hello
Still reproducible on v1.4.31-4
Immediately open request details page

20240125_031829.mp4

@cead22
Copy link
Contributor

cead22 commented Jan 25, 2024

It looks like going into the thread failed again, and I'm pretty sure it's the same issue as this one #33114, which will be fixed as part of this issue #31411, so closing

@cead22 cead22 closed this as completed Jan 25, 2024
@cead22 cead22 self-assigned this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

4 participants