[$500] Violation - Generic error shows up when paying request with violation w/o approval

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.28-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing Pr #31448

Action Performed:

Precondition:

• Admin and employee are part of Control workspace in Old Dot
• The Control workspace has set up Max Expense Amount violation
• Admin is also approver in the Control workspace

1. [Employee] Go to workspace chat
2. [Employee] Create a manual request that exceeds the maximum amount
3. [Employee] Submit the request
4. [Admin] Pay elsewhere the request with violation without approving

Expected Result:

The error message should be more specific to let admin know that they need to approve expense with violation first before they can pay the request

Actual Result:

Generic error message "Unexpected error, please try again later" shows up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6347720_1705676656923.20240119_202829.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0131db0985a6b86fcb
• Upwork Job ID: 1748368695996674048
• Last Price Increase: 2024-02-09

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0131db0985a6b86fcb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[lanitochka17]

#wave6-collect-submitters

[cead22]

The error message should be more specific to let admin know that they need to approve expense with violation first before they can pay the request

I don't know if this is right, because it's unclear what failed. I also think we shouldn't be showing a pay button if you can't pay, but it's possible to approve with violations.

Looking at the logs it looks like payMoneyRequest failed with 406 Report is in incorrect state, which suggests that we shouldn't be showing the button to pay for this report -- @dylanexpensify maybe we should discuss this on slack?

(ps @lanitochka17 please include relevant data in the issue moving forward, like the reportID 1803172850706869 from the URL in your video -- this saves us time when troubleshooting, and if you can clean up the things you're not filling out in the description, eg Email or phone of affected tester (no customers): <blank>, that's also helpful. Let's pay attention to every detail in these issues)

[dylanexpensify]

Oh interesting - if this was free plan I wonder if it'd be the issue we have where we have remaining open reports despite instant submit being live. But seems this is control? Happy to bring to slack

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[dylanexpensify]

confirming today!

[dylanexpensify]

Convo here!

[melvin-bot]

@ntdiary @dylanexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[dylanexpensify]

bumped thread

[dylanexpensify]

summarizing and moving this forward for someone to research

[melvin-bot]

@ntdiary @dylanexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@ntdiary, @dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[dylanexpensify]

Recapping:

• There shouldn't be a pay button if you can't pay
• Violations should show for money requests whether they're submitted or not (we're working on an issue to hide them for money requests that are settled)
• this isn't a bug