[MEDIUM] Violation - Violation for unsubmitted report is visible for Admin after relogin

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.28-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31448

Action Performed:

Precondition:

• Admin and employee are part of Control workspace in Old Dot
• The Control workspace has set up Max Expense Amount violation

1. [Employee] Go to workspace chat
2. [Employee] Create a manual request that exceeds the maximum amount
3. [Employee] Do not submit the request
4. [Admin] Log out and log in

Expected Result:

Violation message and red dot will not be visible for admin because the report with violation is not submitted

Actual Result:

Violation message and red dot is visible for admin after relogin when the report with violation is not submitted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6347733_1705677515837.20240119_210632.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[lanitochka17]

We think that this bug might be related to #wave6.
CC @greg-schroeder

[situchan]

This was also discussed here. Not deploy blocker

[mountiny]

Added to wave 6

[madmax330]

Didn't have time to investigate this yet. Any idea what might be happening off the top of your head @cead22 since you worked on violations IIRC?

[cead22]

Violation message and red dot will not be visible for admin because the report with violation is not submitted

I think this is incorrect. We show RBR for violations only to submitters because they're the ones that can fix them, but we show the violations message to submitter and admins, so I think we can close this. @JmillsExpensify can you confirm?

[melvin-bot]

@cead22 6 days overdue. This is scarier than being forced to listen to Vogon poetry!