[HOLD for payment 2024-02-07] Display Name Appears as "hidden" in Preview Instead of User Email When Searching for New Email

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.31-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1, Sign in to the staging Expensify.
2, Click on the search icon and search for the new email that has never been used before. Observe that the display name is shown as hidden in the preview

Expected Result:

When searching for the new email, the display name should not appear as hidden; instead, it should appear as the user's email in the preview

Actual Result:

When searching for the new email, the display name appears as hidden instead of the user's email in the preview

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6353674_1706125883510.hidden.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The new user name in search page is shown as Hidden.

What is the root cause of that problem?

This happens after #34362. In getDisplayNameForParticipant, we check whether the personal detail isOptimisticPersonalDetail is true or not.

App/src/libs/ReportUtils.ts

Lines 1620 to 1622 in 0d0b0a8

	if (personalDetails.isOptimisticPersonalDetail === true && formattedLogin) {
	return formattedLogin;
	}

It will be true when the personal detail doesn't exist on Onyx.

App/src/libs/ReportUtils.ts

Lines 1598 to 1603 in 0d0b0a8

	return (
	allPersonalDetails?.[accountID] ?? {
	avatar: UserUtils.getDefaultAvatar(accountID),
	isOptimisticPersonalDetail: true,
	}
	);

Then, we also check whether the personal detail has a login or not, but because getPersonalDetailsForAccountID doesn't contain the login data, it will be empty, and because it's empty, "Hidden" will be shown.

This didn't happen previously and we just return an empty login and if it's empty, we fall back to the search value.

App/src/libs/OptionsListUtils.js

Line 1595 in 0d0b0a8

userToInvite.text = userToInvite.text || searchValue;

What changes do you think we should make in order to solve the problem?

I think we can set shouldFallbackToHidden to false when trying to search a new user that we don't have their personal detail yet.

App/src/libs/OptionsListUtils.js

Line 568 in 0d0b0a8

reportName = ReportUtils.getDisplayNameForParticipant(accountIDs[0]) || LocalePhoneNumber.formatPhoneNumber(personalDetail.login);

ReportUtils.getDisplayNameForParticipant(accountIDs[0], false, false)

What alternative solutions did you explore? (Optional)

Because we know that the user doesn't exist on onyx, we can always use the search value as the value for both login and name.

App/src/libs/OptionsListUtils.js

Lines 1594 to 1595 in 0d0b0a8

	userToInvite.login = searchValue;
	userToInvite.text = userToInvite.text || searchValue;

userToInvite.text = searchValue;

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[aimane-chnaif]

@narefyev91 can you please check this?

[narefyev91]

@laurenreidexpensify @aimane-chnaif in case getDisplayNameForParticipant is mostly re-use everywhere - i will just remove && formattedLogin from ReportUtils.ts.
To avoid having issue with empty invited member here

I will just add fallback here inside getAdminRoomInvitedParticipants:

        const name = getDisplayNameForParticipant(id);
        if (name && name?.length > 0) {
            return name;
        }
        return Localize.translateLocal('common.hidden');

[narefyev91]

Will prepare PR shortly

[narefyev91]

@aimane-chnaif PR is ready for review #35142 - will add all platforms attachments as well

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix hidden name is search #35142

If no regressions arise, payment will be issued on 2024-02-07. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertjchen] The PR that introduced the bug has been identified. Link to the PR:
• [@robertjchen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertjchen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertjchen] Determine if we should create a regression test for this bug.
• [@robertjchen] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.