[$500] mWeb - RHP - Close and back buttons unresponsive on touches on "Welcome to Expensify" modal

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.32-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: app should be fresh installed

1. Navigate on public room deeplink https://staging.new.expensify.com/r/3504895439653267
2. Tap on header
3. Tap on close or back button on 'Welcome to Expensify" modal

Expected Result:

"Welcome to Expensify" modal should be dismissed

Actual Result:

Nothing happens. The close and back buttons unresponsive on touches.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6355675_1706267239179.RPReplay_Final1706247699.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015f068dd77dbc82b8
• Upwork Job ID: 1750853562175922176
• Last Price Increase: 2024-02-02

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015f068dd77dbc82b8

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[kbecciv]

We think that this bug might be related to #vip-vsb
CC @quinthar

[strepanier03]

I don't have a physical iOS device and browserstack is bugging out right now. I'll circle back Monday.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens. The close and back buttons unresponsive on touches.

What is the root cause of that problem?

The engagement modal is being shown for anonymous users, which is not correct because by design, it should only show for first time logged in users.

When the engagement modal is opened, the active screen is 2 screens away from the Sidebar that contains the engagement modal, so this logic applies and the engagement modal will be freezed along with the Sidebar, thus closing it doesn't work.

What changes do you think we should make in order to solve the problem?

Do not show engagement modal for anonymous users, we can update here to early return if Session.isAnonymousUser() is true, or we can connect to the SESSION key to the parent component of PurposeForUsingExpensifyModal and do not render the PurposeForUsingExpensifyModal at all if it's anonymous users.

If we don't want to show the engagement modal even after the anonymous user logs in, we can make sure to set isFirstTimeNewExpensifyUser to true and send back from the back-end after the user signs in successfully. Or we can do this in client side (if the user is anonymous) when the user begins the sign in API request in optimisticData and successData.

If instead we want to show the engagement modal after the anonymous user logs in, we have to make sure to remove the policies of the anonymous user in successData after the the user signs in (or the back-end can clear it in Onyx data when returning response). So that this logic will work correctly, otherwise there'll be 2 policies (1 of the signed in user and 1 of the anonymous user) and the engagement modal will not show.

In small screens, we should also only shows the engagement modal if the screen that contains it (Sidebar) is in focus, similar to this logic for the FAB popover that we already use, or we can even move the FloatingActionButtonAndPopover outside of the FreezeWrapper to avoid being affected by the freezing logic.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@strepanier03, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[strepanier03]

Posted for help reproing this here.

[twisterdotcom]

I cannot recreate this on a real iOS device.

RPReplay_Final1706784103.MP4

[twisterdotcom]

@dukenv0307 or @kbecciv is this still a real issue?

[dukenv0307]

I cannot recreate this on a real iOS device.

@twisterdotcom After dismissing the Notification permission dialog, can you try clicking on the header instead of the back button? It won't be reproducible if clicking on back button.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[twisterdotcom]

I still cannot recreate, even if I touch the header. @dukenv0307 if you can recreate on a real iOS device, please comment with a video and I'll reopen.