Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room - Room does not disappear from LHN after leaving the room #35338

Closed
5 of 6 tasks
kbecciv opened this issue Jan 29, 2024 · 5 comments
Closed
5 of 6 tasks

Room - Room does not disappear from LHN after leaving the room #35338

kbecciv opened this issue Jan 29, 2024 · 5 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jan 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.33-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Create a room.
  2. Go to the room.
  3. Leave the room.
  4. Click on the room in LHN.
  5. Navigate to a different chat.

Expected Result:

In Step 3, after leaving the room. room will disappear from LHN.

Actual Result:

In Step 3, after leaving the room. room does not disappear from LHN.
It only disappears after navigating to a different chat.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6360187_1706568000754.bandicam_2024-01-30_06-04-37-173.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 29, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 29, 2024

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Jan 29, 2024

We think that this bug might be related to #vip-vsb
CC @quinthar

@francoisl
Copy link
Contributor

I can't repro on v1.4.33-2, but curious if you could double-check @yuwenmemon as well. Leaving a room should now take you to your last chat, based on #31097.

Screen.Recording.2024-01-29.at.5.36.54.PM.mov

@yuwenmemon
Copy link
Contributor

Yeah, seeing the same result when I test on staging. Closing this.

@yuwenmemon yuwenmemon removed the DeployBlockerCash This issue or pull request should block deployment label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants