-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-09] [$500] mWeb/Safari - Chat - Extra blank space in header on tapping '+' icon in composer #35593
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @arosiclair ( |
Production: RPReplay_Final1706818439.MP4 |
We think that this bug might be related to #vip-vsp |
It's also happening even without typing a message first, just by clicking the safari_mweb_stg.mov |
I can't repro in dev on the |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Job added to Upwork: https://www.upwork.com/jobs/~011c16c18ba938861e |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif ( |
A fix is being worked on as part of #35591 already, no need for new contributions. Thanks! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-09. 🎊 For reference, here are some details about the assignees on this issue:
|
Thanks for handling this @francoisl! Closing this out |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: .1.3.45-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): kiatest.78+mass@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
No visual issues show in conversation history page. No blank space appears in header on tapping '+' icon in composer
Actual Result:
Extra blank space in header on tapping '+' icon in composer
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6364044_1706819425773.RPReplay_Final1706812832.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: