Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-09] [$500] mWeb/Safari - Chat - Extra blank space in header on tapping '+' icon in composer #35593

Closed
1 of 6 tasks
lanitochka17 opened this issue Feb 1, 2024 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: .1.3.45-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): kiatest.78+mass@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Tap FAB >> Start Chat
  2. Navigate to 1:1 DM conversation
  3. Enter a message with more than 2 lines until expand button is displayed in compose box
  4. Tap on arrow button to expand composer
  5. Tap on '+' icon (Note : blank space appears in header)
  6. Dismiss the opened modal (Note : blank space in header)

Expected Result:

No visual issues show in conversation history page. No blank space appears in header on tapping '+' icon in composer

Actual Result:

Extra blank space in header on tapping '+' icon in composer

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6364044_1706819425773.RPReplay_Final1706812832.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011c16c18ba938861e
  • Upwork Job ID: 1753198356592246784
  • Last Price Increase: 2024-02-01
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 1, 2024

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

Production:

RPReplay_Final1706818439.MP4

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@francoisl
Copy link
Contributor

It's also happening even without typing a message first, just by clicking the + button.

safari_mweb_stg.mov

@francoisl
Copy link
Contributor

I can't repro in dev on the 1.3.45-2 tag though for some reason, @arosiclair are you able to?

Copy link

melvin-bot bot commented Feb 1, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@francoisl francoisl added the External Added to denote the issue can be worked on by a contributor label Feb 1, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

Job added to Upwork: https://www.upwork.com/jobs/~011c16c18ba938861e

@melvin-bot melvin-bot bot changed the title mWeb/Safari - Chat - Extra blank space in header on tapping '+' icon in composer [$500] mWeb/Safari - Chat - Extra blank space in header on tapping '+' icon in composer Feb 1, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 1, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

@francoisl
Copy link
Contributor

A fix is being worked on as part of #35591 already, no need for new contributions. Thanks!

@francoisl francoisl removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 2, 2024
@francoisl francoisl added Reviewing Has a PR in review and removed DeployBlockerCash This issue or pull request should block deployment labels Feb 2, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Feb 2, 2024
@melvin-bot melvin-bot bot changed the title [$500] mWeb/Safari - Chat - Extra blank space in header on tapping '+' icon in composer [HOLD for payment 2024-02-09] [$500] mWeb/Safari - Chat - Extra blank space in header on tapping '+' icon in composer Feb 2, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-09. 🎊

For reference, here are some details about the assignees on this issue:

@arosiclair
Copy link
Contributor

Thanks for handling this @francoisl! Closing this out

@arosiclair arosiclair assigned francoisl and unassigned arosiclair Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants