Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-09] [$500] Task - Assignee not updated immediately after admin reassigns task #35597

Closed
5 of 6 tasks
kbecciv opened this issue Feb 1, 2024 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Feb 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.35-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

precondition: as Admin create a workspace and invite Employee A and Employee B

  1. As Employee A create a task in the announce room and assign it to yourself
  2. Log in as Employee B and open the task created by Employee A
  3. On a different device or in incognito log in as Admin
  4. As Admin change the assignee to Employee A

Expected Result:

The assignee is changed for Employee B immediately and Employee B can modify the task

Actual Result:

The assignee is not changed if the task report is open

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6364125_1706824276481.Recording__172.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0100dc89735d2869ee
  • Upwork Job ID: 1753177264991649792
  • Last Price Increase: 2024-02-01
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 1, 2024

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Feb 1, 2024

Issue is not reproducible in prod

Bug6364125_1706824276467.prod.mp4

@kbecciv kbecciv changed the title ask - Assignee not updated immediately after admin reassigns task Task - Assignee not updated immediately after admin reassigns task Feb 1, 2024
@kbecciv
Copy link
Author

kbecciv commented Feb 1, 2024

We think that this bug might be related to #vip-vsb
CC @quinthar

@neil-marcellini
Copy link
Contributor

I'll start investigating, but also labeling this external to get help from contributors in finding the root cause.

@neil-marcellini neil-marcellini added External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Feb 1, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0100dc89735d2869ee

@melvin-bot melvin-bot bot changed the title Task - Assignee not updated immediately after admin reassigns task [$500] Task - Assignee not updated immediately after admin reassigns task Feb 1, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

@mountiny
Copy link
Contributor

mountiny commented Feb 1, 2024

This could have the same root cause as this DB #35574

@mountiny
Copy link
Contributor

mountiny commented Feb 1, 2024

yeah I feel like its similar the managerID change is not listened to, the contributor has a PR going soon so I can add this to testing steps to verify!

@mkhutornyi let's check for this scenario too but I think it might be fixed with your change too

@neil-marcellini
Copy link
Contributor

Awesome thanks so much Vit!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Feb 1, 2024
@mountiny
Copy link
Contributor

mountiny commented Feb 1, 2024

Contributor confirmed this was also fixed

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Feb 2, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 2, 2024
@melvin-bot melvin-bot bot changed the title [$500] Task - Assignee not updated immediately after admin reassigns task [HOLD for payment 2024-02-09] [$500] Task - Assignee not updated immediately after admin reassigns task Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-09. 🎊

For reference, here are some details about the assignees on this issue:

  • @ishpaul777 requires payment (Needs manual offer from BZ)

@ishpaul777
Copy link
Contributor

No payment requires, i was not involved in the PR

@neil-marcellini
Copy link
Contributor

Cool, I'll close this then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants