Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-05] [$500] [Wave Collect] [Ideal Nav] Chat list scroll position is reset on refocus #35602

Closed
6 tasks done
hayata-suenaga opened this issue Feb 1, 2024 · 27 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Feb 1, 2024

Action Performed:

  1. Click the Chat Button on the bottom tab
  2. Make sure that you have enough number of chats so that the list can be scrolled. Scroll the list to a random position.
  3. Click Settings Icon 🔧 to go to Settings page. Click the Chat icon again to navigate back to Chats page.

Expected Result:

The scroll position of the chat list should be preserved.

Actual Result:

The scroll position is reset.

Additional Note

As part of a potential solution, we can make sure that we don't reload the chat/report list when switching between Chat and Settings on the Bottom Tab.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

video -> #33280 (comment)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01af2fb1053774c16b
  • Upwork Job ID: 1754565125866393600
  • Last Price Increase: 2024-02-05
  • Automatic offers:
    • situchan | Reviewer | 0
@hayata-suenaga hayata-suenaga added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 1, 2024
@hayata-suenaga hayata-suenaga self-assigned this Feb 1, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@hayata-suenaga hayata-suenaga changed the title Chat list scroll position is reset on refocus [Wave 8 Ideal Nav] Chat list scroll position is reset on refocus Feb 1, 2024
@hayata-suenaga hayata-suenaga changed the title [Wave 8 Ideal Nav] Chat list scroll position is reset on refocus [Wave 8] [Ideal Nav] Chat list scroll position is reset on refocus Feb 1, 2024
@hayata-suenaga hayata-suenaga mentioned this issue Feb 1, 2024
50 tasks
@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2024
Copy link

melvin-bot bot commented Feb 5, 2024

@muttmuure, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@hayata-suenaga hayata-suenaga added the External Added to denote the issue can be worked on by a contributor label Feb 5, 2024
@melvin-bot melvin-bot bot changed the title [Wave 8] [Ideal Nav] Chat list scroll position is reset on refocus [$500] [Wave 8] [Ideal Nav] Chat list scroll position is reset on refocus Feb 5, 2024
Copy link

melvin-bot bot commented Feb 5, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01af2fb1053774c16b

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 5, 2024
Copy link

melvin-bot bot commented Feb 5, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@melvin-bot melvin-bot bot removed the Overdue label Feb 5, 2024
@jeremy-croff
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are not able to remember the state of the chats in the home route, when navigating to the all-settings page.

What is the root cause of that problem?

This is because BOTTOM_TAB_NAVIGATOR is responsible for both routes and can only display one at a time. When navigating to all-settings it will unmount the chats home route and it's chat components.

What changes do you think we should make in order to solve the problem?

We could move the all-settings route, and place it in our existing RIGHT_MODAL_NAVIGATOR. This Navigator can render alongside the BOTTOM_TAB_NAVIGATOR. this navigator is a modal that would overlay the home chats. So that when you close it would show the previous underlying state.

This implementation requires correct verification of back buttons, as there will be some deeplinking in all the nested navigation routes of all-settings. Overall not a small bug fix but rather a new feature.

What alternative solutions did you explore? (Optional)

@melvin-bot melvin-bot bot added the Overdue label Feb 8, 2024
@hayata-suenaga
Copy link
Contributor Author

still accepting proposals

@melvin-bot melvin-bot bot removed the Overdue label Feb 8, 2024
@adamgrzybowski
Copy link
Contributor

Hey @hayata-suenaga this task may be something I should take a look at

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 9, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented Feb 12, 2024

@muttmuure, @adamgrzybowski, @hayata-suenaga, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

@hayata-suenaga
Copy link
Contributor Author

@adamgrzybowski will take a look at this

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@melvin-bot melvin-bot bot added the Weekly KSv2 label Mar 12, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 29, 2024
@melvin-bot melvin-bot bot changed the title [$500] [Wave Collect] [Ideal Nav] Chat list scroll position is reset on refocus [HOLD for payment 2024-04-05] [$500] [Wave Collect] [Ideal Nav] Chat list scroll position is reset on refocus Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 29, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
  • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@situchan] Determine if we should create a regression test for this bug.
  • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added the Overdue label Apr 8, 2024
@hayata-suenaga
Copy link
Contributor Author

@situchan could you do the checklist when you have time? 😄

@melvin-bot melvin-bot bot removed the Overdue label Apr 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2024
@muttmuure muttmuure added Daily KSv2 and removed Weekly KSv2 labels Apr 17, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 17, 2024
@muttmuure
Copy link
Contributor

Will get to this tomorrow

@muttmuure
Copy link
Contributor

@situchan paid $500 for C+

@muttmuure
Copy link
Contributor

@situchan waiting for you to complete the checklist

@hayata-suenaga hayata-suenaga added Weekly KSv2 and removed Daily KSv2 labels Apr 18, 2024
@hayata-suenaga
Copy link
Contributor Author

@muttmuure, I think situation is OOO for whole April. Let's wait for them to come back. I changed the priority of this issue to weekly 🙇

@melvin-bot melvin-bot bot added the Overdue label Apr 26, 2024
@muttmuure
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Apr 29, 2024
@melvin-bot melvin-bot bot added the Overdue label May 7, 2024
@muttmuure
Copy link
Contributor

Looks like this was already paid out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
No open projects
Archived in project
Status: Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals)
Development

No branches or pull requests

5 participants