Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] IOU - Page shows spinner after returning from Amount editor in confirmation page #35893

Closed
6 tasks done
izarutskaya opened this issue Feb 6, 2024 · 10 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Feb 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v.1.4-37.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Request money > Manual.
  3. Enter amount > Next.
  4. Proceed to confirmation page.
  5. Click Amount.
  6. Click Back button.

Expected Result:

App returns to confirmation page without loading.

Actual Result:

App loads briefly when returning to confirmation page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6369071_1707215636086.bandicam_2024-02-06_08-18-23-328.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01df4afe95e80594cd
  • Upwork Job ID: 1754827608947040256
  • Last Price Increase: 2024-02-06
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 6, 2024
@melvin-bot melvin-bot bot changed the title IOU - Page shows spinner after returning from Amount editor in confirmation page [$500] IOU - Page shows spinner after returning from Amount editor in confirmation page Feb 6, 2024
Copy link

melvin-bot bot commented Feb 6, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01df4afe95e80594cd

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 6, 2024
Copy link

melvin-bot bot commented Feb 6, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

Copy link

melvin-bot bot commented Feb 6, 2024

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 6, 2024
@melvin-bot melvin-bot bot removed the Hourly KSv2 label Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 6, 2024

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@izarutskaya
Copy link
Author

Not repro on production

bandicam.2024-02-06.08-21-37-071.mp4

@izarutskaya
Copy link
Author

We think that this bug might be related to #vip-bills
CC @davidcardoza

@ZhenjaHorbach
Copy link
Contributor

Loading came from this PR
#34075

@shubham1206agra
Copy link
Contributor

This is intentional to show the spinner as it might show outdated currency, which might be confusing to the user. See https://expensify.slack.com/archives/C01GTK53T8Q/p1705504483396879?thread_ts=1704818739.022579&cid=C01GTK53T8Q also.

@luacmartins luacmartins added Hourly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment labels Feb 6, 2024
@luacmartins
Copy link
Contributor

This was indeed discussed and we landed on the current spinner solution. I'm not sure that this is the best UX, but this is definitely not a blocker. Gonna close the issue. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants