[$500] Referral - Referral banner is not permanently dismissed in Search

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when validating PR: #34842

Version Number: v.1.4-37.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Click on the Search bar.
3. Dismiss referral banner.
4. Close the search modal.
5. Reopen the search modal.

Expected Result:

The referral banner will not permanently dismissed.

Actual Result:

The referral banner reappears after reopening the Search modal.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6369092_1707216580629.bandicam_2024-02-06_08-45-04-820.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fa00f6ce5b45ba2f
• Upwork Job ID: 1754832589427269632
• Last Price Increase: 2024-02-13

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fa00f6ce5b45ba2f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #wave8-collect-admins
CC @zanyrenney

[eucool]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Referral banner is not permanently dismissed in Search

What is the root cause of that problem?

We have the shouldShowReferralCTA, passed to the list but we never have the logic for the check

App/src/pages/SearchPage.js

Line 195 in ff23077

shouldShowReferralCTA

What changes do you think we should make in order to solve the problem?

We should use a useState to keep track of the state of the dismissible banner,

We can Add the logic for the check similar to:

App/src/pages/SearchPage/SearchPageFooter.tsx

Line 15 in ff23077

const [shouldShowReferralCTA, setShouldShowReferralCTA] = useState(!dismissedReferralBanners[CONST.REFERRAL_PROGRAM.CONTENT_TYPES.REFER_FRIEND]);

What alternative solutions did you explore? (Optional)

N/A

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Referral - Referral banner is not permanently dismissed in Search

What is the root cause of that problem?

We are not passing two props in OptionsSelector in SearchPage component.
They are - shouldShowReferralCTA (it is true by default, we are not checking if it's already dismissed)
onCallToActionClosed this is method that is called when we close CTA in BaseOptionsSelector. That's why when we open the search page, CTA shows up.

What changes do you think we should make in order to solve the problem?

we need to pass following two props in OptionsSelector component of SearchPage -

1. Pass the shouldShowReferralCTA prop's value based on the ONYX value

dismissedReferralBanners: {
        key: ONYXKEYS.ACCOUNT,
        selector: (data) => data.dismissedReferralBanners || {},
    },

and calculate the value like -

shouldShowReferralCTA={!dismissedReferralBanners[CONST.REFERRAL_PROGRAM.CONTENT_TYPES.REFER_FRIEND]}

2. pass a prop - onCallToActionClosed and it will call - User.dismissReferralBanner(referralContentType);

const dismissCallToAction = (referralContentType) => {
        User.dismissReferralBanner(referralContentType);
    };

What alternative solutions did you explore? (Optional)

[MariaHCD]

cc: @tgolen @hoangzinh

[MariaHCD]

Looking through #34842, it looks like the SearchPage component is being deprecated in favor of SearchPage/index.js as per: #35058

[lukemorawski]

looks like it's going to be fixed in #35058

[hoangzinh]

should we remove DB blocker for this issue and put it holding for #35058?

[tgolen]

Ah yes, thanks for putting a hold on this. This was by design for now and I'm sorry I forgot to update the QA instructions to account for the SearchPage.js deprecation.

[melvin-bot]

@JmillsExpensify, @MariaHCD, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[DylanDylann]

#35058 is merged, let's remove hold in the title

[MariaHCD]

Off hold.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[DylanDylann]

@codinggeek2023 @BhuvaneshPatil COuld you reproduce this issue anymore?

[eucool]

Not reproducible on staging, ig this was fixed in the PR which you mentioned above :)

[DylanDylann]

@JmillsExpensify I also can't reproduce. Let's close this one

[eucool]

lets rest this issue in peace 😆

[MariaHCD]

Thanks, all. Confirmed that the issue is no longer reproducible.