Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room - Adding markdown to room description appears and then disappears #35901

Closed
3 of 6 tasks
lanitochka17 opened this issue Feb 6, 2024 · 5 comments
Closed
3 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.37-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+0507gm@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34150

Action Performed:

  1. Create a new workspace.
  2. Go to 'FAB -> Start Chat> Room
  3. Enter room name
  4. Add custom description with any markdown> Complete the room creating flow
  5. Take a note of the description on chat history, header and edit description

Expected Result:

Description should be displayed with markdown as user enter it

Actual Result:

Adding markdown to description when create room is not applied in header and above composer ( appears in flash and than disappears)
It only applies when edit the description and add markdown. In offline mode, it works fine - added markdown in description while creating room remains on header, above the composer and on edit description page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6369339_1707227714073.Recording__2100.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 6, 2024

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@allgandalf
Copy link
Contributor

Might be a BE issue:

This is what we send when we update description:

image

But this is what we get when we request the details:

image

@Gonals Gonals removed the DeployBlockerCash This issue or pull request should block deployment label Feb 6, 2024
@Gonals
Copy link
Contributor

Gonals commented Feb 6, 2024

Not a blocker. This is a known issue being worked on. Closing.

@Gonals Gonals closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants