Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split scan - On creating Split scan in WS, shows 0 in preview in mweb , app crashes in android #35942

Closed
3 of 6 tasks
lanitochka17 opened this issue Feb 6, 2024 · 5 comments
Closed
3 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.37
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34092

Action Performed:

  1. Go to mweb and app
  2. Open a Worksoace chat
  3. Tap plus icon near compose--- split money
  4. Tap scan
  5. Using camera upload an image
  6. Tap split
  7. In mweb, in scan request preview 0 is shown and in android app crashes

Expected Result:

While making split scan request in Workspace, in mweb, in scan request preview 0 must not be shown and in android app must not crash

Actual Result:

While making split scan request in Workspace, In mweb, in scan request preview 0 is shown and in android app crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6369674_1707243456539.az_recorder_20240206_180530.mp4
Bug6369674_1707243456496.az_recorder_20240206_175443.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 6, 2024

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-split-p2p-chat-groups

@rlinoz
Copy link
Contributor

rlinoz commented Feb 6, 2024

I think this PR caused it: #34564

But apparently a fix is being CP'd, which I think will fix this as well, let's see

@aldo-expensify
Copy link
Contributor

Confirmed that it got fixed by #35915 (comment)

image

@aldo-expensify aldo-expensify removed the DeployBlockerCash This issue or pull request should block deployment label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants