Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - Request Money - Unable to write in field What's this for? #3598

Closed
isagoico opened this issue Jun 15, 2021 · 6 comments · Fixed by #3613
Closed

IOU - Request Money - Unable to write in field What's this for? #3598

isagoico opened this issue Jun 15, 2021 · 6 comments · Fixed by #3613
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@isagoico
Copy link

isagoico commented Jun 15, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in as account B and request money to account C
  2. Write in the field "What's this for?"

Expected Result:

User can write information in the field.

Actual Result:

Unable to write information in the field.

Workaround:

Unknown.

Platform:

Where is this issue confirmed?

Web
iOS
Android
Desktop App
Mobile Web ✔️

Version Number: 1.0.69-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5114676_15.06.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@isagoico isagoico added DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 labels Jun 15, 2021
@MelvinBot
Copy link

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@isagoico isagoico changed the title IOU - Request Money - Unable to write in field "What's this for?" IOU - Request Money - Unable to write in field What's this for? Jun 15, 2021
@isagoico isagoico added DeployBlockerCash This issue or pull request should block deployment and removed DeployBlockerCash This issue or pull request should block deployment labels Jun 15, 2021
@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Jun 15, 2021
@parasharrajat
Copy link
Member

Damn, Safari always has some problem. I can confirm that this works absolutely fine on chrome M-web. And it seems a regression from #3193

@flodnv flodnv removed their assignment Jun 16, 2021
@jasperhuangg
Copy link
Contributor

jasperhuangg commented Jun 16, 2021

Yup, Apple uses a different CSS rendering engine from Chromium based browsers which can cause issues like this, I can confirm that this doesn't work on Safari on desktop web either.

The fix definitely involves some random CSS finesse.

@parasharrajat Since you submitted that other PR, do you have any ideas as to what might have broke this?

@roryabraham
Copy link
Contributor

I can confirm that manually changing the css property -webkit-user-select: none to -webkit-user-select: text fixes the problem. However, giving the textInput style the property userSelect: 'text' does not seem to work. For some reason the property is overridden:

image

I also doubt we'll be able to open an issue in react-native-web, because he will probably close it since we are not on the latest package version.

@roryabraham roryabraham self-assigned this Jun 16, 2021
@roryabraham
Copy link
Contributor

It's not pretty, but I've found a solution.

@roryabraham roryabraham added the Reviewing Has a PR in review label Jun 16, 2021
@roryabraham
Copy link
Contributor

Verified that this is fixed on staging, checking it off the list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants