-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-20] Login - Welcome modal is not dismissed after selecting an option #36265
Comments
Triggered auto assignment to @abekkala ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think this bug might be related to #vip-vsb |
Triggered auto assignment to @rlinoz ( |
@teneeto curious if this could be related to our recent changes 🤔 |
Probably it's some problem here since the screens are in the nav stack now. We might just want to |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-19. 🎊 |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
NAB b/c #36283 got to prod yesterday! |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-20. 🎊 |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@marcaaron I want to make sure I'm not overlooking a contributor (for payment purposes) but it appears that you implemented the fix and @rlinoz did the PR review so this was fully internal? |
You are correct @abekkala 😄 |
Yep you got it. I think we can close this one out. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.39-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:
Expected Result:
The welcome modal is closed and user is redirected to LHN.
Actual Result:
The welcome modal is not closed.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6373563_1707484177351.Screen_Recording_20240209_134842_New_Expensify.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: