[HOLD for payment 2024-02-20] [$500] Expense - Pay elsewhere button does not show up for admin after approving the report

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v.1.4-40-2
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Precondition:

• Admin and employee are in the Collect workspace.
• Admin is also the approver.
• Reimbursement is set to "Indirect" on Old Dot.

1. Go to staging.new.expensify.com
2. [Employee] Create a money request in workspace chat.
3. [Employee] Submit the report.
   4, [Admin] Approve the report.

Expected Result:

Pay elsewhere button should show up for admin after approving the report.

Actual Result:

Pay elsewhere button does not show up for admin after approving the report.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6377518_1707788705788.20240213_043830.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01639b285c7d4a3b6d
• Upwork Job ID: 1757345839678914560
• Last Price Increase: 2024-02-13

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01639b285c7d4a3b6d

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #wave7-collect-approvers
CC @RachCHopkins

[Beamanator]

I mentioned this in #wave7, thanks! 👍

[Beamanator]

This potentially looks expected, as of this PR: #35347

Which is related to this issue: #34951

And this bug report: https://expensify.slack.com/archives/C049HHMV9SM/p1705978407170839

cc @JmillsExpensify can you confirm?

[JmillsExpensify]

Discussing in Slack.

[mountiny]

The PR was reverted

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Update logic to display pay button in paid policies" #36424

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
• [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@DylanDylann] Determine if we should create a regression test for this bug.
• [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: