[HOLD for payment 2024-02-26] Profile - Tapping share code link directs to hmm not here page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.41
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/

2. Tap profile icon

3. Tap share code ---- copy URL

4. Navigate to LHN

5. Tap on a report

6. Paste the URL in compose box

7. Send the message

8. Tap on the URL link

Expected Result:

Tapping share code link must direct to profile page

Actual Result:

Tapping share code link directs to hmm not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6378728_1707864241718.az_recorder_20240214_005141.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Auto-assign attempt failed, all eligible assignees are OOO.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue

Profile - Tapping share code link directs to hmm not here page

What is the root cause of that problem?

This is due to

App/src/pages/ShareCodePage.tsx

Line 71 in 023d62c

const url = isReport ? `${urlWithTrailingSlash}${ROUTES.REPORT_WITH_ID.getRoute(report.reportID)}` : `${urlWithTrailingSlash}${ROUTES.PROFILE.getRoute(session?.accountID ?? '')}`;

Using session to find acountid, but we don't subscribe to session anywhere in the code.

What changes do you think we should make in order to solve the problem?

Remove session and use

const url = isReport ? `${urlWithTrailingSlash}${ROUTES.REPORT_WITH_ID.getRoute(report.reportID)}` : `${urlWithTrailingSlash}${ROUTES.PROFILE.getRoute(currentUserPersonalDetails.accountID ?? '')}`;

BONUS:

Need to do same here

App/src/pages/ShareCodePage.tsx

Line 65 in 023d62c

return session?.email;

Replace it with currentUserPersonalDetails.login

What alternative solutions did you explore? (Optional)

Same problem is with SidebarLinksData

[shubham1206agra]

Offending PR #35841

[rushatgabhane]

@lukemorawski would you be able to fix this, please

[lukemorawski]

@rushatgabhane sure will have a look

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mountiny]

This is fixed

[mallenexpensify]

Confirming that the root issue for this regression was addressed, no action needed here as BZ

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix/Profile - Tapping share code link directs to hmm not here page #36507

If no regressions arise, payment will be issued on 2024-02-26. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@techievivek] The PR that introduced the bug has been identified. Link to the PR:
• [@techievivek] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@techievivek] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@techievivek] Determine if we should create a regression test for this bug.
• [@techievivek] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[techievivek]

This was the Offending PR #35841, and the original author only fixed the regression.

[techievivek]

Maybe we can add this regression test? @mallenexpensify, but Applause seems to have caught this bug so we may have a test already for this?

1. Tap profile icon
2. Tap share code ---- copy URL
3. Navigate to LHN
4. Tap on a report
5. Paste the URL in compose box
6. Send the message
7. Tap on the URL link
8. Confirm you can see the copied user's profile
9. Verify that no errors appear in the JS console

[techievivek]

@rushatgabhane @cristipaval, this has originated from this PR #35841

Regarding this step

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Could we have done anything different/better that would have made us catch this bug during the review? Or should we do :nothing: here?

[mallenexpensify]

Thanks @techievivek , we're all good.

TestRail GH created https://github.com/Expensify/Expensify/issues/371221