Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Workspace - System message for workspace description edit shows from "" to "x" #36595

Closed
6 tasks done
kbecciv opened this issue Feb 15, 2024 · 28 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Feb 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.42-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create a new workspace.
  3. Go to workspace profile.
  4. Click Add description.
  5. Add a description and save it.
  6. Go to #admin room.

Expected Result:

The system message shows <updated the description of this workspace to "m">.

Actual Result:

The system message shows <updated the description of this workspace from "" to "x">.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6380761_1708008341144.bandicam_2024-02-15_13-54-52-146.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01890415a5997d6fe7
  • Upwork Job ID: 1772400631077556224
  • Last Price Increase: 2024-03-25
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Feb 15, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 15, 2024

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Feb 15, 2024

We think that this bug might be related #wave5-free-submitters
CC @dylanexpensify

@Julesssss Julesssss added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment labels Feb 15, 2024
@Julesssss
Copy link
Contributor

We should fix this, but I'm removing the blocker label as it shouldn't block the release 👍

@Julesssss Julesssss added Bug Something is broken. Auto assigns a BugZero manager. and removed Hourly KSv2 labels Feb 15, 2024
Copy link

melvin-bot bot commented Feb 15, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MitchExpensify
Copy link
Contributor

Why would we expect this when the description was blank?:

The system message shows <updated the description of this workspace to "m">.

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

@Julesssss, @MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Julesssss
Copy link
Contributor

Why would we expect this when the description was blank?:

Oh right. Good point. @kbecciv any other issue here we're missing, or can we close?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 20, 2024
@MitchExpensify
Copy link
Contributor

Oh right. Good point. @kbecciv any other issue here we're missing, or can we close?

Friendly bump @kbecciv

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 23, 2024
@kbecciv
Copy link
Author

kbecciv commented Feb 26, 2024

No other issues @MitchExpensify

@kbecciv
Copy link
Author

kbecciv commented Mar 20, 2024

@MitchExpensify Reopening the issue.
Previously, we had an empty workspace description, but now there is a default workspace description (due to a new feature). However, the issue remains unresolved.
Could you please advise whether it's preferable to open a new issue or to keep this one open as it is?

Bug6420607_1710946984357.such.mp4

@kbecciv kbecciv reopened this Mar 20, 2024
@MitchExpensify
Copy link
Contributor

Yeah lets solve that here, good catch. Can you please update the OP accordingly? Thanks

@situchan
Copy link
Contributor

Unassigning as backend issue and no C+ required

@situchan situchan removed their assignment Mar 28, 2024
@MitchExpensify MitchExpensify added the Internal Requires API changes or must be handled by Expensify staff label Mar 30, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 30, 2024
Copy link

melvin-bot bot commented Mar 30, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @hungvu193 (Internal)

@melvin-bot melvin-bot bot removed the Overdue label Mar 30, 2024
@hungvu193
Copy link
Contributor

unassigning myself as this no need C+

@hungvu193 hungvu193 removed their assignment Apr 1, 2024
@MitchExpensify
Copy link
Contributor

Will try track down an Internal volunteer as a next step

@MitchExpensify MitchExpensify added Weekly KSv2 and removed Daily KSv2 labels Apr 1, 2024
@Julesssss Julesssss removed their assignment Apr 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2024
@MitchExpensify
Copy link
Contributor

No bites yet

@trjExpensify do we ever apply hot picks label to polish?

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@trjExpensify
Copy link
Contributor

Yep, you can add the Hot picks label and move it into the Hot picks section of the project board so anyone browsing it can see it in that column. Once it's picked up, remove the label and move it back into Polish. 👍

@MitchExpensify MitchExpensify added the Hot Pick Ready for an engineer to pick up and run with label Apr 17, 2024
@chiragsalian chiragsalian self-assigned this Apr 22, 2024
@chiragsalian chiragsalian added the Reviewing Has a PR in review label Apr 23, 2024
@trjExpensify trjExpensify removed Hot Pick Ready for an engineer to pick up and run with Help Wanted Apply this label when an issue is open to proposals by contributors labels Apr 25, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels May 16, 2024
Copy link

melvin-bot bot commented May 16, 2024

This issue has not been updated in over 15 days. @chiragsalian, @MitchExpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@MitchExpensify MitchExpensify added the Hot Pick Ready for an engineer to pick up and run with label May 19, 2024
@trjExpensify
Copy link
Contributor

Why did you move this back, @MitchExpensify? @chiragsalian put up a PR here: https://github.com/Expensify/Web-Expensify/pull/41774

@chiragsalian
Copy link
Contributor

Also that PR of mine went live last month

@chiragsalian
Copy link
Contributor

Actually im just going to close out this issue since its done. Feel free to reopen if something is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review
Projects
No open projects
Archived in project
Development

No branches or pull requests

9 participants