Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New architecture] Popover modals are not visible when opened #36662

Closed
2 of 6 tasks
j-piasecki opened this issue Feb 16, 2024 · 22 comments
Closed
2 of 6 tasks

[New architecture] Popover modals are not visible when opened #36662

j-piasecki opened this issue Feb 16, 2024 · 22 comments
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@j-piasecki
Copy link
Contributor

j-piasecki commented Feb 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


This issue is related to the ongoing new architecture adoption. It was reported on the build with new architecture enabled on the relevant PR.


Version Number: 1.4.42-1
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777 here and here
Slack conversation:

Action Performed:

Open a popover modal

  • by clicking the FAB on the LHN
  • by clicking the ➕ icon in the composer
  • by pressing the photo icon in the Add receipt screen

Expected Result:

The popover modal should appear

Actual Result:

The backdrop is visible but the popover itself is not.

Workaround:

Unknown, should be fixed by 6816b93

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

![popover1](https://github.com/Expensify/App/assets/21055725/1673a686-f3f0-4513-8c0b-65b4689284a4)
popover2.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013d3bfa0df549c01f
  • Upwork Job ID: 1768714498647588864
  • Last Price Increase: 2024-03-15
@j-piasecki j-piasecki added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 16, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Feb 19, 2024

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
Copy link

melvin-bot bot commented Feb 21, 2024

Huh... This is 4 days overdue. Who can take care of this?

@ishpaul777
Copy link
Contributor

Not able to repro with latest build 👍

Copy link

melvin-bot bot commented Feb 23, 2024

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@MitchExpensify
Copy link
Contributor

Just to be sure before I close, what "popover" are you referring to in the issue @ishpaul777 ?

@melvin-bot melvin-bot bot removed the Overdue label Feb 26, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Feb 29, 2024
Copy link

melvin-bot bot commented Mar 1, 2024

this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@MitchExpensify
Copy link
Contributor

Just to be sure before I close, what "popover" are you referring to in the issue @ishpaul777 ?

bump @ishpaul777

@melvin-bot melvin-bot bot removed the Overdue label Mar 2, 2024
@ishpaul777
Copy link
Contributor

ishpaul777 commented Mar 2, 2024

Sorry i missed the ping earlier, the issue was found while testing #13767 and created for tracking purpose, now its fixed in PR but we decide to keep it open so this can be tested again by QA team on staging once Pr is merged

Copy link

melvin-bot bot commented Mar 5, 2024

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Mar 5, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

Whoops! This issue is 2 days overdue. Let's get this updated quick!

@MitchExpensify
Copy link
Contributor

Waiting on this PR to hit staging to test again

@melvin-bot melvin-bot bot removed the Overdue label Mar 7, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@MitchExpensify
Copy link
Contributor

PR hasn't hit staging yet to retest

Copy link

melvin-bot bot commented Mar 14, 2024

Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Mar 14, 2024
@tgolen
Copy link
Contributor

tgolen commented Mar 15, 2024

This issue is unassigned. Who is working on this and taking responsibility for it? @ishpaul777 would that be you or would it be @MitchExpensify ?

@melvin-bot melvin-bot bot removed the Overdue label Mar 15, 2024
@ishpaul777
Copy link
Contributor

ishpaul777 commented Mar 15, 2024

This issue was found while testing PR #13767 and is resolved in the PR #13767 but we have kept it open so QA will retest when PR hits staging. Any bugs with [New architecture] that are unassigned are probably only for tracking purpose.

Copy link

melvin-bot bot commented Mar 15, 2024

this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Mar 15, 2024

This comment was marked as off-topic.

This comment was marked as off-topic.

@tgolen
Copy link
Contributor

tgolen commented Mar 15, 2024

Hm, but we don't keep around unassigned issues just for tracking purposes. If the problem has been fixed, and nothing is left to do, then I'm just going to close it. Thanks!

@tgolen tgolen closed this as completed Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
Development

No branches or pull requests

5 participants