[HOLD PR #13767][$500] [New architecture] Screen flashes when dismissing a popover modal

[j-piasecki]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

This issue is related to the ongoing new architecture adoption. It was reported on the build with new architecture enabled on the relevant PR.

---

Version Number: 1.4.42-1
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777 here
Slack conversation:

Action Performed:

• open any report
• tap on the three dots in the upper right corner
• tap on the Pin or Unpin option

Expected Result:

The popover should close with a smooth animation

Actual Result:

The popover closes causing screen flashing

Workaround:

Unknown, should be fixed by 27846dd

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

popover-flash.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01229cd35e1df3c9b9
• Upwork Job ID: 1759305165281734656
• Last Price Increase: 2024-02-18

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01229cd35e1df3c9b9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[mallenexpensify]

Assuming, since this issue was created by @j-piasecki and they didn't assign to themselves, that we want this to be a normal bug report. My guess is that it should be External, since the flash is on the front end (I think) so I'm creating a job for this. Comment if you disagree @j-piasecki , we can add Vit back here for 👀, if needed (but I prefer not to, to not distract them).

[ishpaul777]

Hey @mallenexpensify, this is one of the issues found while testing #13767, most issues are resolved already, we decided to create individual issues for better tracking bugs found and later retesting issues on staging once PR is merged and deployed.

Any bug with [New Architecture] is for tracking purposes only so not yet external.

[mallenexpensify]

Thanks for the context @ishpaul777 , should I put this on hold, pending #13767 ?

I removed External and Help Wanted labels.

[ishpaul777]

I think we can add [WIP] here, even though this issue is fixed with latest change but it would be good to keep it open so we can test again after PR is on staging

[melvin-bot]

@fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@fedirjh 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[fedirjh]

@ishpaul777 What is the status of this issue?

@mallenexpensify Can please add a weekly label to this issue?

[ishpaul777]

Issue is fixed by 27846dd in Pr we are keeping it open so this can be tested again in staging once Pr is merged.

[mallenexpensify]

Bumped to weekly. Assigned myself too for 👀.

[melvin-bot]

@mallenexpensify @fedirjh this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@mallenexpensify, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

@ishpaul777 is there an issue or PR we'll holding on? I see 27846dd above, i haven't held an issue on a commit before.

[fedirjh]

@mallenexpensify I guess this should be held for :

• Enable Fabric and TurboModules on iOS & Android #13767

[ishpaul777]

yes! @fedirjh is right 👍

[mallenexpensify]

Thanks @fedirjh and @ishpaul777 , put on hold.

[melvin-bot]

@mallenexpensify, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

on hold

[mallenexpensify]

• Enable Fabric and TurboModules on iOS & Android #13767 (review)

Lotta requested changes being worked on

[j-piasecki]

All issues will be tested for the new arch pr in staging