Android - Payment -Missing the dropdown for payment option, so Pay with Venmo isn't visible

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Sign-up to Expensify.cash with a US phone number and validate that account (Account A)
2. Create another account with a different US phone number (Account B) that has the Venmo app installed on their mobile device.
3. As account A, Complete the request money flow and send a payment request to account B
4. Log-in as account B and click the pay button
5. Verify that Pay with Venmo is visible as an option in the dropdown

Expected Result:

Pay with Venmo` is visible as an option in the dropdown

Actual Result:

Missing the dropdown for payment option, so Pay with Venmo isn't visible

Workaround:

No workaround found to pay with venmo app.

Platform:

Where is this issue occurring?

Web
iOS
Android ✔️
Desktop App
Mobile Web

Version Number: 1.0.72-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Issue is not reproducible with the same account in iOS.

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

Actions been taken:

1. Asked in #expensify-open-source for help.
2. Currently trying to get Venmo installed in my emulator in order to reproduce the issue.

[luacmartins]

@isagoico Were you logged in to Venmo when you reproduced this issue?

[luacmartins]

Waiting on answer from @isagoico while trying to change default IOU currency to USD on test accounts so addVenmoPaymentOptionIfAvailable() runs.

[isagoico]

Mmmm I think the option should show if the user has the app installed which was the case on the issue. She tried the same (with the same account) in iOS and the option to pay via Venmo appeared. I'll confirm with the tester if the she was logged in or not.

[luacmartins]

Managed to reproduce the issue. Currently investigating the diffrence in iOS and Android responses.

[roryabraham]

@isagoico Can we retest this and check it off if resolved?

[isagoico]

Seems like the PR is still not in staging. We're still able to reproduce the issue in build 1.0.73-0

[luacmartins]

@roryabraham how can we get this PR to staging? #3713

[parasharrajat]

CP staging label is needed. But I think its too late PR is already merged.

[luacmartins]

Added CP Staging label to PR.

[roryabraham]

@luacmartins and I got this settled 1:1, but yes in general the CP Staging label should be applied before the PR is merged, and then it will be immediately CP'd upon merge. However, if we forget to do that, then Expensify employees can just ping me in the #deployers slack channel to ask for an E.cash PR to be CP'd after-the-fact. Right now only @AndrewGable and myself have permission to manually CP, but we will probably open that up to other Expensify employees soon.

[isagoico]

Issue is fixed in build 1.0.73-2 🎉