[HOLD for payment 2024-03-22] [$250] [Simplified Collect] [Profile] Add QRCode icon to share button in Workspace profile page and Trash can icon to workspace delete button

[luacmartins]

Coming from here, we want to add a QR Code icon to the share button in the Workspace profile page.

Also as follow up to #37528, please add trashcan icon to the workspace delete button #37528

cc @narefyev91

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f1e510102dc2c0f1
• Upwork Job ID: 1760727451269500928
• Last Price Increase: 2024-03-07

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[shawnborton]

cc @Expensify/design

[dannymcclain]

Alrighty here's what I've got written out for the button specs. @shawnborton & @dubielzyk-expensify, does this all look right to you? Anything you want to change while we're updating the global styles for the buttons?

Showing light mode and dark mode for visual reference, but the variables should be the same across themes.

[narefyev91]

Hi! I'm Nicolay from Callstack - expert contributor group. I'll work on this issue so please assign me. Thank you.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f1e510102dc2c0f1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[dubielzyk-expensify]

That looks right to me @dannymcclain

[shawnborton]

Looks amazing! We should describe our buttons that way in the Figma design system file. I think we chatted about that previously, but I love how you've laid everything out here.

[melvin-bot]

@luacmartins, @kevinksullivan, @sobitneupane, @narefyev91 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

This is low priority right now. @narefyev91 will get to it once his higher priority items are done.

[luacmartins]

Same as above

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Updated button specification with Icon #37966

If no regressions arise, payment will be issued on 2024-03-22. 🎊

For reference, here are some details about the assignees on this issue:

• @sobitneupane requires payment through NewDot Manual Requests
• @narefyev91 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sobitneupane]

Rather than a bug, it's improvement in the app (addition of some buttons and change in styling). So, I don't think the checklist is relevant here.

[luacmartins]

Just pending payment

[sobitneupane]

@kevinksullivan I will need payment summary to request payment.

[luacmartins]

PAYMENT SUMMARY
Fix: @narefyev91 - invoiced
PR Review: @sobitneupane $250 for PR review

[luacmartins]

Just pending payment

[luacmartins]

Bump for payment @kevinksullivan

[melvin-bot]

@luacmartins, @kevinksullivan, @sobitneupane, @narefyev91 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sobitneupane]

I will request payment in newdot.

[luacmartins]

Ok, so seems like we can close this issue since the payment summary was posted and @sobitneupane will request payment via NewDot.

[JmillsExpensify]

$250 approved for @sobitneupane