[HOLD for payment 2024-04-05] [$500] Settings - Preferences page is visible for a moment when navigate via text link in Focus Mode popup

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.46-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34069

Action Performed:

1. Open New Expensify app.
2. Login
3. Popup appears
4. Click on the text link “Settings”

Expected Result:

Priority mode page opens

Actual Result:

Preferences page is visible for a moment when navigate via text link in Focus Mode popup

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6398320_1709303268047.And_Chat_-_Popup_window_appears_that_can_t_close_tapping_outside.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0128371baf608716e9
• Upwork Job ID: 1765238125791371264
• Last Price Increase: 2024-03-06
• Automatic offers:
• DylanDylann | Reviewer | 0
• tienifr | Contributor | 0

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[JmillsExpensify]

I'm also not sure, so let's see what the community says.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0128371baf608716e9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Preferences page is visible for a moment when navigate via text link in Focus Mode popup

What is the root cause of that problem?

• settings/preferences/priority-mode is defined as the right modal here
• settings/preferences is full-screen here

On large screen we need to show full screen for settings/preferences and just open the right modal for settings/preferences/priority-mode so we need to render both of them
But on small screen we just can show one of them at a time so we don't need to render full-screen when open right modal

What changes do you think we should make in order to solve the problem?

The logic to show both full-screen and right modal is here, if metainfo.isFullScreenNavigatorMandatory is true we will show full-screen page

We get metainfo from this function

so we need the logic to check if the users are in small screen then disable isFullScreenNavigatorMandatory

function getAdaptedState(state: PartialState<NavigationState<RootStackParamList>>, policyID?: string): GetAdaptedStateReturnType {
...
 if (rhpNavigator) {
...
        if(isSmallScreenWidth){
            metainfo.isFullScreenNavigatorMandatory = false
        }

The fastest way to detect the small screen is using Dimension API

    const screenWidth = Dimensions.get('screen').width;
    const isSmallScreenWidth = screenWidth <= variables.mobileResponsiveWidthBreakpoint;

We also can pass isSmallScreenWidth from component but we have to do it in all place

What alternative solutions did you explore? (Optional)

We can consider to remove SCREENS.SETTINGS.PREFERENCES.PRIORITY_MODE in SCREENS.SETTINGS.PREFERENCES.ROOT in here

Result

Screen.Recording.2024-03-06.at.14.07.38.mov

[DylanDylann]

@tienifr's proposal looks good to me. We also should set isCentralPaneAndBottomTabMandatory is false in the small screen

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mkhutornyi]

Can we hold this for ideal nav v2?

[DylanDylann]

@thienlnam Please uphold this issue. I still can reproduce after #37421 is merged

[DylanDylann]

Waiting for a approval from @thienlnam

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[tienifr]

The PR is up

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Preferences page is visible for a moment when navigate via text link in Focus Mode popup #38977

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @tienifr requires payment automatic offer (Contributor)
• @DylanDylann requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
• [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@DylanDylann] Determine if we should create a regression test for this bug.
• [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[DylanDylann]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal
Pre-requisite: Using an account that enables focus mode

1. Open New Expensify app.
2. Login
3. Popup appears
4. Click on the text link “Settings”
5. Verify that Preferences page is not visible and priority mode page opens

Do we agree 👍 or 👎

[JmillsExpensify]

Payment summary:

• Contributor: @tienifr $500
• Contributor+: @DylanDylann $500

[JmillsExpensify]

For the regression test, isn't there a pre-requisite that you're in focus mode? I don't quite understand how that's going to prevent this from being tested and happening again.

[DylanDylann]

@JmillsExpensify Yeah, we should have a pre-requisite as you said. I updated

[JmillsExpensify]

All contributors paid