[HOLD for payment 2024-04-05] [$500] [Performance] Memoize SidebarLinksData to reduce the getOrderedReportIDs calls

[mountiny]

Coming from the Callstack performance audit

From the hermes profile trace, we see that getOrderedReportIDs from Sidebarlinks takes about ~8 seconds and it happens in 3 occurrences. Which means we have getOrderedReportIDs being called for roughly 3 times. We can reduce it to 2 times only by adding memoization to Sidebarlinks . This reduces the app startup by ~2.5 seconds, which is a huge reduction.
Details for the implementation can be seen in the commit

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011e08e65659afcb69
• Upwork Job ID: 1772400240247611392
• Last Price Increase: 2024-03-25

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

@rinej can you please comment here so I can assign you?

[rinej]

@mountiny sure

[mountiny]

Thanks

[rinej]

Hello @mountiny, we decided to hold this off until we complete the remaining audit implementations because as of now, we are not yet sure whether we prefer the extra render without memo or increased rendering time with memo. We will evaluate this after all the audit action items are completed.

[mountiny]

Thanks for an update

[alexpensify]

Weekly Update: Going through an audit

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011e08e65659afcb69

[melvin-bot]

Current assignee @c3024 is eligible for the External assigner, not assigning anyone new.

[alexpensify]

Weekly Update: The PR is under review and making progress

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Audit][Implementation] - Memoize SidebarLinksData  #37205

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @rinej does not require payment (Contractor)
• @c3024 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

$500 to @c3024 only

[alexpensify]

@c3024 - please apply to the job below and I can complete the payment process tomorrow:

https://www.upwork.com/jobs/~011e08e65659afcb69

Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @rinej is from an agency-contributor and not due payment
• ROLE: @c3024 paid $(500) via Upwork (LINK)

BugZero Checklist (@alexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1772400240247611392/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[alexpensify]

@c3024 - please accept in Upwork and I can complete the payment process. Thanks!

[c3024]

@alexpensify accepted, thanks.

[alexpensify]

Awesome, I've completed the payment process in Upwork.