[HOLD for payment 2024-03-25] Invite - Selected contacts with names disappeared from the invite listing page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+omq1@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34993

Action Performed:

1. Open app
2. Open any DM with other user
3. Write a message
4. Tap and hold on the message in chat
5. Select "Reply in Thread"
6. Write any message
7. Tap on Header > Members > Invite
8. Perform a search using a portion of the email contact, for example, "omd10"
   (applausetester+101321@applause.expensifail.com applausetester+omd10@applause.expensifail.com )
9. Scroll down and select a contact with a first and last name set e.g. "Pes Patron"
10. Select a contact where the first and last name are not set in the profile
11. Scroll up

Expected Result:

Selected contacts should be displayed on top of the listing page

Actual Result:

Contacts with first and last names set in the profile disappeared from the listing page when users selected them

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6412901_1710372788470.RPReplay_Final1710372738.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[suneox]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invite - Selected contacts with names disappeared from the invite listing page

What is the root cause of that problem?

the condition at this line has filter out the selected contacts from the list. Due to function check includes option.text?.toLowerCase().includes(searchValue) will return false and the operation ?? is check null or undefined despite of option.login include a search value also return null.

What changes do you think we should make in order to solve the problem?

Change condition to

    const isPartOfSearchTerm = option.text?.toLowerCase().includes(searchValue) || option.login?.toLowerCase().includes(searchValue);
    return isPartOfSearchTerm || isOptionInPersonalDetails;

What alternative solutions did you explore? (Optional)

[rlinoz]

This is already a bug in prod when inviting someone to a room, so removing the blocker label.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix room invite selected options filter #38327

If no regressions arise, payment will be issued on 2024-03-25. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

👋 checklist time here please, @ishpaul777.

[ishpaul777]

The PR that introduced the bug has been identified. Link to the PR: #34956

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/34956/files#r1548644054

Determine if we should create a regression test for this bug. - yes

Regression test proposal:

Precondition: Have a user who has the display name completely different than the email, use this user in step 8 and 9
eg: Display name: Bob Lee and email: testing@gmail.com

1. Open app
2. Open any DM with other user
3. Write a message
4. Tap and hold on the message in chat
5. Select "Reply in Thread"
6. Write any message
7. Tap on Header > Members > Invite
8. Perform a search using a portion of the email contact
9. Scroll down and select a contact with a first and last name set
10. Scroll up and check that the user is showing up as selected
11. Without changing the search term, select a user who doesn't have a display name
12. Scroll up and check that both users are showing up as selected

Do we agree 👍 or 👎

[trjExpensify]

Thanks! Applause caught this with those regression steps, so I don't think we need to add a new one.

Payment summary as follows:

• $500 to @ishpaul777 for the C+ review. Offer sent!

[ishpaul777]

Thanks offer accepted! @trjExpensify

[trjExpensify]

Paid!