[HOLD for payment 2024-03-25] [HOLD for payment 2024-03-22] [$500] App crashes when navigating to another report while playing a video

[luacmartins]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

1. Play a video
2. Navigate to another report

Expected Result:

App doesn't crash

Actual Result:

App crashes

Workaround:

Reload app

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2024-03-14_17-36-05.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013fb810bafe68c299
• Upwork Job ID: 1768419024646979584
• Last Price Increase: 2024-03-14
• Automatic offers:
• situchan | Contributor | 0

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @luacmartins is eligible for the Engineering assigner, not assigning anyone new.

[jeremy-croff]

I can take this, thanks.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013fb810bafe68c299

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[jeremy-croff]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When we play a video and navigate to a different report we crash!

What is the root cause of that problem?

It's a regression from 6f92384
Where we are no longer typesafe.

As we unload the video the ref becomes undefined, and calling stop on the video now crashes.
There's a cleanup that happends on reportId change

App/src/components/VideoPlayerContexts/PlaybackContext.tsx

Line 80 in 6f92384

useEffect(() => {

But by the time we are here it seems the ref is destroyed.

What changes do you think we should make in order to solve the problem?

We should make it typesafe again to unblock the deployment by adding the optional chaining back

What alternative solutions did you explore? (Optional)

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix(38362): add optional chain for stopasync video ref #38364

If no regressions arise, payment will be issued on 2024-03-22. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment automatic offer (Contributor)
• @jeremy-croff requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix(38362): add optional chain for stopasync video ref #38364

If no regressions arise, payment will be issued on 2024-03-25. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment automatic offer (Contributor)
• @jeremy-croff requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: [TS migration] Migrate VideoPlayerContexts component files to TypeScript #37134
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [TS migration] Migrate VideoPlayerContexts component files to TypeScript #37134 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Send any video on any chat
2. Play a video
3. While playing, navigate to another report
4. Verify that app doesn't crash

[garrettmknight]

Payment Summary:

• Contributor: @jeremy-croff $500
• Reviewer: @situchan $500 paid via Upwork

Upwork job: https://www.upwork.com/ab/applicants/1768419024646979584/hired

[garrettmknight]

@jeremy-croff request payment whenever you're ready.

[jeremy-croff]

@jeremy-croff request payment whenever you're ready.

Thanks, what's the process for this?

[garrettmknight]

Ah, my mistake! It just looks like you need a manual offer in Upwork, not that you're on our NewDot payments process. Just sent you an offer from Upwork.

[jeremy-croff]

Ah, my mistake! It just looks like you need a manual offer in Upwork, not that you're on our NewDot payments process. Just sent you an offer from Upwork.

Thanks! Accepted it.
Is there any benefits or process to look into getting on NewDot payments process? (Mainly because UpWork takes a large fee )

[garrettmknight]

Paid! We're working on enabling more contributors to use our NewDot payment process, but it's a bit of work to do right now so it's not a super high priority.