[HOLD for payment 2024-04-09] [$500] Weird pop up when hit esc key immediately, after clicking uparrow to edit the last message

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @iwiznia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710538564054589

Action Performed:

1. Open any chat
2. hit up arrow key to edit the last message
3. Immediately hit esckey

Expected Result:

Edit action should cancel and no pop up to edit the message

Actual Result:

Edit box reappears after a second
NOTE: This is happening occasionally

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019e21e5668d684c41
• Upwork Job ID: 1770530705295687680
• Last Price Increase: 2024-03-20
• Automatic offers:
• ntdiary | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[slafortune]

Unable to reproduce - will test again this week a bit.

[slafortune]

still unable to reproduce - closing

[iwiznia]

I got it today, this is certainly not fixed

[iwiznia]

I am reproducing it as we speak

[slafortune]

Cool! Can you record it and give more details? I am not able to

2024-03-20_13-28-10.mp4

[iwiznia]

Yep, here you go:

Screen.Recording.2024-03-20.at.3.32.10.PM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019e21e5668d684c41

[slafortune]

not sure why a C+ wasn't added - I'll have to play with the labels applied

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[roitman-g]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When clicking up arrow key (to edit the last message) and escape (to cancel editing the last message), the popup to edit the message appears back again after a second. Issue is easy to reproduce this way - go to some chat (chat 1), go to another chat (chat 2), return back to the exact previous chat 1, after this the issue is constant and not occasional. And if you keep repeating it long enough sometimes the popup is not closable at all.

What is the root cause of that problem?

The debounced function that saves the draft is not being cancelled when the component (ReportActionItemMessageEdit) unmounts.

What changes do you think we should make in order to solve the problem?

Instead of cancelling the debounced function when deleting the draft, it is a better way to cancel it when the component unmounts - this solves all the issues I stated in re-state of the proposal section and everything works smoothly.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

📣 @roitman-g! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[roitman-g]

@slafortune thank you for inviting me in slack.
I already applied for the job on Upwork, but still was not hired though.

[slafortune]

The action of hiring does not happen right away, it typically happens once the issue moves to a payment state in the 7 holding days for any regressions. The slack invite may take a bit more time than I thought, but we'll get that addressed as soon as possible.

You won't need that to complete this job, but feel free to shout here if you have questions or issues that do need to be asked/addressed via slack.

[slafortune]

You're next step is comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻

[roitman-g]

@slafortune sorry for my misunderstanding. Does this mean my next step is to submit the PR and then link it here saying it is ready for the review? Or just state when I will post it? If so I can make the PR ready for the review in the next two hours.

[roitman-g]

PR ready for review #39027

[roitman-g]

@slafortune I still was not invited to the slack channel, could you tell me when I can approximately expect to be invited if it is possible?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• 38483 - fix edit message draft reappearing #39027

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

• @ntdiary requires payment automatic offer (Reviewer)
• @roitman-g requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ntdiary] Determine if we should create a regression test for this bug.
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[roitman-g]

@slafortune @ntdiary is there any help needed from my end right now?

[slafortune]

@roitman-g thanks, nothing else! I just sent an offer for you to accept, I will pay that tomorrow.

[roitman-g]

@slafortune thank you! could you also invite me to the slack channel?

[slafortune]

@roitman-g I was able to invite you to slack, you should be all set 👍 Payment made!

@ntdiary Can you please complete the checklist and then accept the offer sent - https://www.upwork.com/nx/wm/offer/101529844

[roitman-g]

@slafortune thank you very much!

[ntdiary]

@ntdiary Can you please complete the checklist and then accept the offer sent - https://www.upwork.com/nx/wm/offer/101529844

@slafortune, thank you! Have just accepted it. 😄

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: Edit Comments #2320
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Edit Comments #2320 (comment)
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@ntdiary] Determine if we should create a regression test for this bug. yeah
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. As below
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Regression steps:

1. Login with an account
2. Go to any chat and send a message (chat 1)
3. Go to another chat (chat 2)
4. Go back to chat 1
5. Press up (to start editing last message) and escape (to stop editing last message) quickly
6. Make sure the edit composer input won't appear after a second for no reason.

[slafortune]

Paid!