[Guided Setup Stage 2] Update HandleSpecialChatReportsOnMergeAccount to handle system DM

[francoisl]

Part of the "wave-collect – Build Stage 2 of Guided Setup" project

Main issue: https://github.com/Expensify/Expensify/issues/356685
Doc section: https://docs.google.com/document/d/10bhCv6XtzzqEZQ9tzxFwAz4lowgjOhsFqz13BMq6Iu4/edit#heading=h.dmxmb440p80k (and section below)
Project: https://github.com/orgs/Expensify/projects/129

Feature Description

• Create the concept of read-only messages by updating the permissions mechanism
• Create a read-only system DM using the new Expensify persona for existing and new users

Remaining tasks

• Make Account writing to chat/task report without permission throw
• Handle MergeAccount
  • Update HandleSpecialChatReportsOnMergeAccount to handle system DM
  • Remove HandleSelfDMOnMergeAccount from AuthCommandMap

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010dca0075d6efe79d
• Upwork Job ID: 1770904803490025472
• Last Price Increase: 2024-03-21

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010dca0075d6efe79d

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @getusha (Internal)

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[francoisl]

This is all backend work and will be taken care of internally, no need for a C+ here.

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

Still need a volunteer here, Melv.

[flodnv]

Taking this! @francoisl I'm assuming I need to work on
2. Creating the system DM (phase 2)
3. Enforcing read-only permissions for the system DM (phase 2)

?

[flodnv]

• Added a few doc comments on these 2 sections
• Pushed WIP PR
• Paused at Finally, we'll need to make a few general changes to accommodate system DMs:, will resume once we figure out answers to my questions

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

Putting this back on weekly. 👍

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

Going back to weekly, hoping @NikkiWines might be able to get to it this week.

[NikkiWines]

Discussing with @francoisl today about whether or not we want to update this command to

A. Take in the type of special chat report we'd want to merge (i.e. system, selfDM, etc.)

or

B. Merge all the special type DMs in one go instead of passing a specific type.

Not sure if we have a scenario where we'd want to merge the selfDM but not system DM, since this is called when the user merges their account. So I'm leaning more towards B at the moment

[francoisl]

I'd say option B, otherwise we'd need that command twice (once for self DMs, once for system DMs).

[NikkiWines]

PR is in the works! Draft is up here

[NikkiWines]

Logic is working as expected, finishing up tests tomorrow morning

[NikkiWines]

PR is in review!

[NikkiWines]

PR has been merged!

[trjExpensify]

Dope, deployed. Good to close?

[NikkiWines]

Yes should be all set here!

[trjExpensify]

Wahoo!