Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public room - new messages button is displayed for anon user and it can not be dismissed #38870

Closed
2 of 6 tasks
kbecciv opened this issue Mar 23, 2024 · 7 comments
Closed
2 of 6 tasks
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Mar 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.56-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4444224
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to any public room as anonymous user, e. g. https://staging.new.expensify.com/r/3504895439653267

Expected Result:

New messages button should not appear as there is no new messages.

Actual Result:

New messages button is always shown for anon user and it can not be dismissed.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423847_1711149332885.2024-03-23_00-08-55.1.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Mar 23, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 23, 2024

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Mar 23, 2024

We think that this bug might be related to #vip-vsb

@rlinoz
Copy link
Contributor

rlinoz commented Mar 25, 2024

This is probably being caused by this PR #30269

@rlinoz
Copy link
Contributor

rlinoz commented Mar 25, 2024

It looks like might be the same root cause of #38848

@rlinoz
Copy link
Contributor

rlinoz commented Mar 25, 2024

Maybe @perunt or @roryabraham can help?

@yuwenmemon
Copy link
Contributor

Closing in favor of #38848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants