[$250] [HOLD for payment 2024-04-09] [HOLD for payment 2024-04-05] [Dev] Infinite loop of GetOlderActions calls

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: only reproducible on dev at the time of creating - 1.4.56-6 at the time of wriging
Reproducible in staging?: no
Reproducible in production?: no
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1711476371378119?thread_ts=1711147499.521539&cid=C049HHMV9SM

Action Performed:

1. Open a report
2. Go offline
3. Send a message
4. Delete the message
5. Go online

Expected Result:

1. The message you sent and deleted offline should be deleted.
2. The skeleton indicator should not appear indefinitely on the report. You should not see an infinite loop of GetOlderAction requests in the network tab.

Actual Result:

Skeleton indicator appears and flashes infinitely, along with an infinite loop of GetOlderActions requests.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

https://expensify.slack.com/archives/C049HHMV9SM/p1711476420432379?thread_ts=1711147499.521539&cid=C049HHMV9SM

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017cac9b0408529fb8
• Upwork Job ID: 1778528999840456704
• Last Price Increase: 2024-04-11

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[roryabraham]

sup @kevinksullivan. I already have a WIP PR to fix this here. It's an hourly because it's reproducible only on dev. That means that as soon as we deploy staging it will become a deploy blocker

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @roryabraham is eligible for the Engineering assigner, not assigning anyone new.

[roryabraham]

ok, jumping back into the PR

[roryabraham]

Got that PR ready for review: #39024

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create generic network layer logic for conflicting write requests #39024

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@roryabraham] The PR that introduced the bug has been identified. Link to the PR:
• [@roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@roryabraham] Determine if we should create a regression test for this bug.
• [@roryabraham] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create generic network layer logic for conflicting write requests #39024

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@roryabraham] The PR that introduced the bug has been identified. Link to the PR:
• [@roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@roryabraham] Determine if we should create a regression test for this bug.
• [@roryabraham] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017cac9b0408529fb8

[melvin-bot]

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

[kevinksullivan]

@ishpaul777 offer sent, lmk when you accept!

[ishpaul777]

hello 👋 @kevinksullivan, i was not involved in the PR no idea why melvin says i am eligible for payment 🤔

[kevinksullivan]

ah ok, weird haha. Thanks for letting me know. I will close this out then.